Page MenuHomePhabricator

Merge #14244: amount: Move CAmount CENT to unit test header
ClosedPublic

Authored by nakihito on Mon, Mar 16, 23:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC58be0d7ee902: Merge #14244: amount: Move CAmount CENT to unit test header
Summary

fa84723e73 amount: Move CAmount CENT to unit test header (MarcoFalke)

Pull request description:

`CAmount` is currently not type-safe. Exporting a constant (`CENT`) that is commonly not referred to by that name might be confusing. `CENT` is only used in two places prior to this commit (`ParseMoney` and `MIN_CHANGE`). So replace these with constants relative to `COIN` and move `CENT` to the unit test header.

Tree-SHA512: 5273e96d8664ced6ae211abde2e20bc763e6e99f89404eec02c621f29e1d235e5f9b1ade933743843fae16fc24b643f883deda9221e3d9fd31229d2ab63a914f

Backport of Core PR14244

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Mon, Mar 16, 23:18
Owners added a reviewer: Restricted Owners Package.Mon, Mar 16, 23:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Mar 16, 23:18
teamcity edited the summary of this revision. (Show Details)Mon, Mar 16, 23:19

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Tue, Mar 17, 02:28
This revision is now accepted and ready to land.Tue, Mar 17, 02:28