Page MenuHomePhabricator
Differential D5489

Merge #14244: amount: Move CAmount CENT to unit test header
ClosedPublic
Actions

Authored by nakihito on Mar 16 2020, 23:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING58be0d7ee902: Merge #14244: amount: Move CAmount CENT to unit test header
rABC58be0d7ee902: Merge #14244: amount: Move CAmount CENT to unit test header
Summary

fa84723e73 amount: Move CAmount CENT to unit test header (MarcoFalke)

Pull request description:

`CAmount` is currently not type-safe. Exporting a constant (`CENT`) that is commonly not referred to by that name might be confusing. `CENT` is only used in two places prior to this commit (`ParseMoney` and `MIN_CHANGE`). So replace these with constants relative to `COIN` and move `CENT` to the unit test header.

Tree-SHA512: 5273e96d8664ced6ae211abde2e20bc763e6e99f89404eec02c621f29e1d235e5f9b1ade933743843fae16fc24b643f883deda9221e3d9fd31229d2ab63a914f

Backport of Core PR14244

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14244
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9835
Build 17540: Default Diff Build & Tests
Build 17539: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 16 2020, 23:18
Owners added a reviewer: Restricted Owners Package.Mar 16 2020, 23:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2020, 23:18
teamcity edited the summary of this revision. (Show Details)Mar 16 2020, 23:19

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 16 2020, 23:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B9835: Diff 16963.Mar 16 2020, 23:31
teamcity added a comment.Mar 16 2020, 23:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix accepted this revision.Mar 17 2020, 02:28
This revision is now accepted and ready to land.Mar 17 2020, 02:28
Closed by commit rABC58be0d7ee902: Merge #14244: amount: Move CAmount CENT to unit test header (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMar 17 2020, 18:20
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC58be0d7ee902: Merge #14244: amount: Move CAmount CENT to unit test header.
nakihito added a commit: rSTAGING58be0d7ee902: Merge #14244: amount: Move CAmount CENT to unit test header.Apr 7 2020, 23:21

Revision Contents
Changeset List

PathSize
src/
1 line
bench/
16 lines
4 lines
test/
2 lines
util/
2 lines
wallet/
2 lines

Diff 16963

View Options

src/amount.h

Loading...
View Options

src/bench/ccoins_caching.cpp

Loading...
View Options

src/bench/rpc_mempool.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/util/moneystr.cpp

Loading...
View Options

src/wallet/coinselection.h

Loading...