Page MenuHomePhabricator

[CMAKE] Improve the toolchain files
ClosedPublic

Authored by Fabien on Wed, Mar 18, 12:21.

Details

Summary

This sets a few more variables in the toolchain files, that will allow
us to have a better detection of the target architecture in the cmake
list files.

There is no change in behavior.

Test Plan

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Mar 18, 12:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 18, 12:21
deadalnix requested changes to this revision.Wed, Mar 18, 13:46
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/platforms/Linux32.cmake
5 ↗(On Diff #16992)

This is clearly dependent on CMAKE_SYSTEM_PROCESSOR, just like the others.

This revision now requires changes to proceed.Wed, Mar 18, 13:46
Fabien updated this revision to Diff 16997.Wed, Mar 18, 14:03

Name the toolchain prefix after the target processor name.

deadalnix accepted this revision.Wed, Mar 18, 16:48
This revision is now accepted and ready to land.Wed, Mar 18, 16:48
This revision was automatically updated to reflect the committed changes.