Page MenuHomePhabricator
Differential D5501

[CMAKE] Improve the toolchain files
ClosedPublic
Actions

Authored by Fabien on Mar 18 2020, 12:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING49dab06701be: [CMAKE] Improve the toolchain files
rABC49dab06701be: [CMAKE] Improve the toolchain files
Summary

This sets a few more variables in the toolchain files, that will allow
us to have a better detection of the target architecture in the cmake
list files.

There is no change in behavior.

Test Plan

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 18 2020, 12:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2020, 12:21
teamcity added a comment.Mar 18 2020, 12:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added a child revision: D5480: [SECP256K1] CMake: Build the ARM ASM field implementation.Mar 18 2020, 12:29
teamcity added a comment.Mar 18 2020, 12:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9857: Diff 16992.Mar 18 2020, 12:31
deadalnix requested changes to this revision.Mar 18 2020, 13:46
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/platforms/Linux32.cmake
5 ↗(On Diff #16992)

This is clearly dependent on CMAKE_SYSTEM_PROCESSOR, just like the others.

This revision now requires changes to proceed.Mar 18 2020, 13:46
Fabien updated this revision to Diff 16997.Mar 18 2020, 14:03

Name the toolchain prefix after the target processor name.

teamcity added a comment.Mar 18 2020, 14:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 18 2020, 14:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9859: Diff 16997.Mar 18 2020, 14:13
deadalnix accepted this revision.Mar 18 2020, 16:48
This revision is now accepted and ready to land.Mar 18 2020, 16:48
Closed by commit rABC49dab06701be: [CMAKE] Improve the toolchain files (authored by Fabien). · Explain WhyMar 19 2020, 09:13
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC49dab06701be: [CMAKE] Improve the toolchain files.
Fabien added a commit: rSTAGING49dab06701be: [CMAKE] Improve the toolchain files.Apr 7 2020, 23:22

Revision Contents
Changeset List

PathSize
cmake/
platforms/
6 lines
6 lines
6 lines
6 lines
8 lines
6 lines
6 lines

Diff 17030

View Options

cmake/platforms/Linux32.cmake

Loading...
View Options

cmake/platforms/Linux64.cmake

Loading...
View Options

cmake/platforms/LinuxAArch64.cmake

Loading...
View Options

cmake/platforms/LinuxARM.cmake

Loading...
View Options

cmake/platforms/OSX.cmake

Loading...
View Options

cmake/platforms/Win32.cmake

Loading...
View Options

cmake/platforms/Win64.cmake

Loading...