Page MenuHomePhabricator

[depends] expat 2.2.5, miniupnpc 2.0.20180203
ClosedPublic

Authored by Fabien on Wed, Mar 18, 16:16.

Details

Summary
miniupnpc changelog:
http://miniupnp.free.fr/files/changelog.php?file=miniupnpc-2.0.20180203.tar.gz
2.0.20180203 includes fixes for the recent buffer overflow and segfault
issues, see miniupnp/miniupnp#268.

expat changelog:
https://github.com/libexpat/libexpat/blob/R_2_2_5/expat/Changes
2.2.2 & 2.2.3 included security fixes.

Also includes latest config.guess and config.sub.

This updates our depends version for expat, miniupnpc, config.guess and
config.sub.
The ccache version is NOT updated (see D5503).

It also includes a fix for miniupnpc.

Backport of core PR12402 and PR12466.

Depends on D5502 and D5503.

*Note to reviewers:* the diff ends up fairly large due to the pull of
config.guess and config.sub. However this is mostly formatting changes
(${FOO} vs $FOO in particular), and there was no merge conflict
during the cherry-pick.

Test Plan

Run the Gitian builds twice, ensure the build is still deterministic.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Mar 18, 16:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 18, 16:17
teamcity edited the summary of this revision. (Show Details)Wed, Mar 18, 16:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Wed, Mar 18, 16:17

Pending gitian builds

Fabien requested review of this revision.Wed, Mar 18, 20:06

All gitian builds ran twice on a different agent, the build is deterministic.

deadalnix requested changes to this revision.Thu, Mar 19, 00:14
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
depends/packages/miniupnpc.mk
12 ↗(On Diff #17002)

It's missing various stuff here.

This revision now requires changes to proceed.Thu, Mar 19, 00:14
Fabien requested review of this revision.Thu, Mar 19, 09:10
Fabien added inline comments.
depends/packages/miniupnpc.mk
12 ↗(On Diff #17002)
deadalnix accepted this revision.Thu, Mar 19, 13:17
This revision is now accepted and ready to land.Thu, Mar 19, 13:17
This revision was automatically updated to reflect the committed changes.