Page MenuHomePhabricator
Differential D5514

build: set minimum supported macOS to 10.12
ClosedPublic
Actions

Authored by Fabien on Mar 19 2020, 15:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf7352a1260f0: build: set minimum supported macOS to 10.12
rABCf7352a1260f0: build: set minimum supported macOS to 10.12
Summary
Reasoning:

    10.10 has been unsupported since July 2017 (~3 years at v0.20.0
release)
    10.11 has been unsupported since July 2018 (~2 years at v0.20.0
release)
    macOS users are consistent at upgrading to new releases.
    Qt 5.12 LTS only supports macOS > 10.12. As long as we're supporting
macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the
v0.20.0 release.

Backport of core PR17550.

Test Plan

Run the OSX Gitian build.
Run the binary on 10.12 and 10.15.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR17550
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9887
Build 17634: Default Diff Build & Tests
Build 17633: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 19 2020, 15:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 15:49
teamcity edited the summary of this revision. (Show Details)Mar 19 2020, 15:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 19 2020, 16:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 19 2020, 16:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9887: Diff 17041.Mar 19 2020, 16:53
deadalnix accepted this revision.Mar 19 2020, 17:31
This revision is now accepted and ready to land.Mar 19 2020, 17:31
Closed by commit rABCf7352a1260f0: build: set minimum supported macOS to 10.12 (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyMar 20 2020, 19:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf7352a1260f0: build: set minimum supported macOS to 10.12.
Fabien mentioned this in D5530: Fix the OSX gitian build.Mar 21 2020, 12:00
Fabien mentioned this in rABC368a0fa5ec89: Fix the OSX gitian build.Mar 21 2020, 14:36
Fabien mentioned this in D5540: Thread names in logs and deadlock debug tools.Mar 23 2020, 15:32
Fabien mentioned this in rABC3372a6e87684: Thread names in logs and deadlock debug tools.Mar 24 2020, 09:39
Fabien added a commit: rSTAGINGf7352a1260f0: build: set minimum supported macOS to 10.12.Apr 7 2020, 23:24
Fabien mentioned this in rSTAGING368a0fa5ec89: Fix the OSX gitian build.
Fabien mentioned this in rSTAGING3372a6e87684: Thread names in logs and deadlock debug tools.
Fabien mentioned this in D7241: [CMAKE] Fix the Info.plist template minimum version.Aug 24 2020, 11:56
Fabien mentioned this in rABC493fc56ce5c8: [CMAKE] Fix the Info.plist template minimum version.Aug 24 2020, 16:06

Revision Contents
Changeset List

PathSize
cmake/
platforms/
4 lines
contrib/
gitian-descriptors/
2 lines
depends/
4 lines
hosts/
2 lines
doc/
3 lines
share/
qt/
2 lines

Diff 17041

View Options

cmake/platforms/OSX.cmake

Loading...
View Options

contrib/gitian-descriptors/gitian-osx.yml

Loading...
View Options

depends/Makefile

Loading...
View Options

depends/hosts/darwin.mk

Loading...
View Options

doc/release-notes.md

Loading...
View Options

share/qt/Info.plist.in

Loading...