Page MenuHomePhabricator

Fix remaining test_bitcoin.cpp references (should be setup_common.cpp)
ClosedPublic

Authored by Fabien on Thu, Mar 19, 18:00.

Details

Summary

Due to out of order landing of D5494, some reference were not updated.

Test Plan

export CC=clang CXX=clang++

../configure --enable-fuzz --with-sanitizers=fuzzer,address \
  --disable-wallet \
  --disable-bench \
  --with-utils=no \
  --with-daemon=no \
  --with-libs=no \
  --with-gui=no \
  --with-seeder=no \
  --with-miniupnpc=no  \
  --disable-zmq
make
cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" \
  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Mar 19, 18:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 19, 18:00
jasonbcox accepted this revision.Thu, Mar 19, 18:04
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/Makefile.test.include
62 ↗(On Diff #17051)

I should point out that I did bring this up here: https://reviews.bitcoinabc.org/D5494#inline-34018

This revision is now accepted and ready to land.Thu, Mar 19, 18:04
Fabien added inline comments.Thu, Mar 19, 18:07
src/Makefile.test.include
62 ↗(On Diff #17051)

My bad, I didn't understand the comment in D5494, just thought you were asking where the fuzz line came from

Fabien edited the test plan for this revision. (Show Details)Thu, Mar 19, 18:26