Page MenuHomePhabricator

Rename test_bitcoin to test/setup_common
ClosedPublic

Authored by Fabien on Tue, Mar 17, 13:29.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCe289a06d6055: Rename test_bitcoin to test/setup_common
Summary

Original replacement script:

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/test_bitcoin\.(h|cpp)/setup_common.\1/g'
$(git grep -l test_bitcoin)
git mv ./src/test/test_bitcoin.h   ./src/test/setup_common.h
git mv ./src/test/test_bitcoin.cpp ./src/test/setup_common.cpp
sed -i -e 's/BITCOIN_TEST_TEST_BITCOIN_H/BITCOIN_TEST_SETUP_COMMON_H/g'
./src/test/setup_common.h
-END VERIFY SCRIPT-

Partial backport of core PR15788:
https://github.com/bitcoin/bitcoin/pull/15788/commits/fa821904bf8870d8957a82ea65c0c7a8e84272a6#diff-cbf056cfc6c760726f2dff1391fd37d8

Depends on D5493.

This touches a lot of files, but is renaming only and unfortunately
cannot be split without breaking the build.

Test Plan
make
make check
./src/bench/bench_bitcoin

ninja
ninja check
ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Mar 17, 13:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 17, 13:29
teamcity edited the summary of this revision. (Show Details)Tue, Mar 17, 13:29

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Thu, Mar 19, 00:06
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/Makefile.test.include
60 ↗(On Diff #16972)

I don't see this change in your stack anywhere. When does it come into play?

This revision is now accepted and ready to land.Thu, Mar 19, 00:06
This revision was automatically updated to reflect the committed changes.