Page MenuHomePhabricator

tests: Use MakeUnique to construct objects owned by unique_ptrs
AcceptedPublic

Authored by Fabien on Mon, Dec 2, 13:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title.

Backport of core PR14287:
https://github.com/bitcoin/bitcoin/pull/14287/files

Depends on D4588.

Several changes are missing because already in our codebase.

Test Plan
ninja check bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14287
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8370
Build 14759: Bitcoin ABC Buildbot
Build 14758: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Dec 2, 13:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 2, 13:36
deadalnix accepted this revision.Mon, Dec 2, 17:26
This revision is now accepted and ready to land.Mon, Dec 2, 17:26