Page MenuHomePhabricator

tests: Use MakeUnique to construct objects owned by unique_ptrs
ClosedPublic

Authored by Fabien on Dec 2 2019, 13:36.

Details

Summary

As per title.

Backport of core PR14287:
https://github.com/bitcoin/bitcoin/pull/14287/files

Depends on D4588.

Several changes are missing because already in our codebase.

Test Plan
ninja check bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14287
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9319
Build 16574: Default Diff Build & Tests
Build 16573: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 2 2019, 17:26