Page MenuHomePhabricator

fuzz: Script validation flags
Changes PlannedPublic

Authored by Fabien on Dec 4 2019, 15:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Add a fuzzer test for the validation flags.

Completes backport of core PR15399 (commit fab15ff):
https://github.com/bitcoin/bitcoin/pull/15399/commits/fab15ff70e8db26942db83a9aab7ebf974e8b6b2

Depends on D4628.

Test Plan
./test/fuzz/test_runner.py -l DEBUG <path_to_your_corpus> script_flags

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15399_part2
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8402
Build 14821: Bitcoin ABC Buildbot
Build 14820: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 4 2019, 15:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2019, 15:27
deadalnix added inline comments.Dec 9 2019, 00:40
src/test/fuzz/CMakeLists.txt
15

I'm fairly confident this isn't the ay it supposed to be done. I'm somewhat surprised that that works at all :)

I think you are making this more complex that it needs to be by only setting the flag on some specific files.

65

Is that important that the target has this very specific name? Because if not, then simplify.

Fabien added inline comments.Dec 9 2019, 07:42
src/test/fuzz/CMakeLists.txt
65

No it's not. It is only done that way for consistency with autotools and I'll be happy to clean it.
I'd better do it in another diff though, as it requires to update autotools as well (otherwise the fuzz/test_runner.py will be broken, as for now it parses the Makefile.test.include to build the list of fuzz tests).

Fabien planned changes to this revision.Dec 12 2019, 11:05