Page MenuHomePhabricator
Differential D5499

Make the fuzzer test runner compatible with cmake
ClosedPublic
Actions

Authored by Fabien on Mar 17 2020, 15:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING101549ed6c60: Make the fuzzer test runner compatible with cmake
rABC101549ed6c60: Make the fuzzer test runner compatible with cmake
Summary

The current implementation of the fuzzer test runner reads the
Makefile.test.include to extract a list of the fuzz targets that it
can run.
This diff makes it explore the actually built binaries instead, so it
can work with both autotools and cmake.

Creating a link at build time with autotools makes it easier to run with
out-of-tree builds.

Depends on D4629.

Test Plan
export CC=clang CXX=clang++
../configure --enable-fuzz --with-sanitizers=fuzzer,address \
  --disable-wallet \
  --disable-bench \
  --with-utils=no \
  --with-daemon=no \
  --with-libs=no \
  --with-gui=no \
  --with-seeder=no
make
./test/fuzz/test_runner.py -l DEBUG <path_to_corpus>
cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" \
  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja bitcoin-fuzzers link-fuzz-test_runner.py
./test/fuzz/test_runner.py -l DEBUG <path_to_corpus>

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 17 2020, 15:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2020, 15:34
teamcity added a comment.Mar 17 2020, 15:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 17 2020, 15:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9849: Diff 16977.Mar 17 2020, 15:45
deadalnix requested changes to this revision.Mar 19 2020, 00:39
deadalnix added a subscriber: deadalnix.

Looks like there is some duplication with the test runner.

This revision now requires changes to proceed.Mar 19 2020, 00:39
deadalnix accepted this revision.Mar 19 2020, 13:15
This revision is now accepted and ready to land.Mar 19 2020, 13:15
Closed by commit rABC101549ed6c60: Make the fuzzer test runner compatible with cmake (authored by Fabien). · Explain WhyMar 19 2020, 16:02
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC101549ed6c60: Make the fuzzer test runner compatible with cmake.
Fabien added a commit: rSTAGING101549ed6c60: Make the fuzzer test runner compatible with cmake.Apr 7 2020, 23:23

Revision Contents
Changeset List

PathSize
1 line
test/
fuzz/
34 lines

Diff 17049

View Options

configure.ac

Loading...
View Options

test/fuzz/test_runner.py

Loading...