Page MenuHomePhabricator
Differential D5494

Rename test_bitcoin to test/setup_common
ClosedPublic
Actions

Authored by Fabien on Mar 17 2020, 13:29.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe289a06d6055: Rename test_bitcoin to test/setup_common
rABCe289a06d6055: Rename test_bitcoin to test/setup_common
Summary

Original replacement script:

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/test_bitcoin\.(h|cpp)/setup_common.\1/g'
$(git grep -l test_bitcoin)
git mv ./src/test/test_bitcoin.h   ./src/test/setup_common.h
git mv ./src/test/test_bitcoin.cpp ./src/test/setup_common.cpp
sed -i -e 's/BITCOIN_TEST_TEST_BITCOIN_H/BITCOIN_TEST_SETUP_COMMON_H/g'
./src/test/setup_common.h
-END VERIFY SCRIPT-

Partial backport of core PR15788:
https://github.com/bitcoin/bitcoin/pull/15788/commits/fa821904bf8870d8957a82ea65c0c7a8e84272a6#diff-cbf056cfc6c760726f2dff1391fd37d8

Depends on D5493.

This touches a lot of files, but is renaming only and unfortunately
cannot be split without breaking the build.

Test Plan
make
make check
./src/bench/bench_bitcoin

ninja
ninja check
ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15788_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9844
Build 17556: Default Diff Build & Tests
Build 17555: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 17 2020, 13:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2020, 13:29
teamcity edited the summary of this revision. (Show Details)Mar 17 2020, 13:29

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 17 2020, 13:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B9844: Diff 16972.Mar 17 2020, 13:40
teamcity added a comment.Mar 17 2020, 13:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien added a child revision: D5498: Bump copyright headers in tests (part3).Mar 17 2020, 14:06
jasonbcox accepted this revision.Mar 19 2020, 00:06
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/Makefile.test.include
60

I don't see this change in your stack anywhere. When does it come into play?

This revision is now accepted and ready to land.Mar 19 2020, 00:06
Closed by commit rABCe289a06d6055: Rename test_bitcoin to test/setup_common (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMar 19 2020, 15:59
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe289a06d6055: Rename test_bitcoin to test/setup_common.
Fabien mentioned this in D5516: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp).Mar 19 2020, 18:00
Fabien mentioned this in rABC561eefdbe8d2: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp).Mar 19 2020, 18:16
Fabien added a commit: rSTAGINGe289a06d6055: Rename test_bitcoin to test/setup_common.Apr 7 2020, 23:23
Fabien mentioned this in rSTAGING561eefdbe8d2: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp).

Large Diff

This large diff affects 122 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
4 lines
4 lines
4 lines
bench/
2 lines
2 lines
qt/
test/
2 lines
2 lines
2 lines
2 lines
rpc/
test/
2 lines
test/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
setup_common.h
test_bitcoin.h
6 lines
setup_common.cpp
test_bitcoin.cpp
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
wallet/
test/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 16972

View Options

doc/unit-tests.md

View Options

src/Makefile.bench.include

View Options

src/Makefile.qttest.include

View Options

src/Makefile.test.include

Loading...
View Options

src/bench/CMakeLists.txt

View Options

src/bench/bench.cpp

View Options

src/qt/test/CMakeLists.txt

View Options

src/qt/test/addressbooktests.cpp

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/rpc/test/server_tests.cpp

View Options

src/test/CMakeLists.txt

View Options

src/test/activation_tests.cpp

View Options

src/test/addrman_tests.cpp

View Options

src/test/allocator_tests.cpp

View Options

src/test/amount_tests.cpp

View Options

src/test/arith_uint256_tests.cpp

View Options

src/test/avalanche_tests.cpp

View Options

src/test/base32_tests.cpp

View Options

src/test/base58_tests.cpp

View Options

src/test/base64_tests.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/bitmanip_tests.cpp

View Options

src/test/blockchain_tests.cpp

View Options

src/test/blockcheck_tests.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/blockfilter_tests.cpp

View Options

src/test/blockindex_tests.cpp

View Options

src/test/blockstatus_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/bswap_tests.cpp

View Options

src/test/cashaddr_tests.cpp

View Options

src/test/cashaddrenc_tests.cpp

View Options

src/test/checkdatasig_tests.cpp

View Options

src/test/checkpoints_tests.cpp

View Options

src/test/checkqueue_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/compress_tests.cpp

View Options

src/test/config_tests.cpp

View Options

src/test/core_io_tests.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/cuckoocache_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/descriptor_tests.cpp

View Options

src/test/dstencode_tests.cpp

View Options

src/test/excessiveblock_tests.cpp

View Options

src/test/feerate_tests.cpp

View Options

src/test/finalization_tests.cpp

View Options

src/test/flatfile_tests.cpp

View Options

src/test/getarg_tests.cpp

View Options

src/test/hash_tests.cpp

View Options

src/test/key_io_tests.cpp

View Options

src/test/key_properties.cpp

View Options

src/test/key_tests.cpp

View Options

src/test/limitedmap_tests.cpp

View Options

src/test/mempool_policy_tests.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/merkle_tests.cpp

View Options

src/test/merkleblock_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/monolith_opcodes_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/net_tests.cpp

View Options

src/test/netbase_tests.cpp

View Options

src/test/op_reversebytes_tests.cpp

View Options

src/test/pmt_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/test/pow_tests.cpp

View Options

src/test/prevector_tests.cpp

View Options

src/test/radix_tests.cpp

View Options

src/test/raii_event_tests.cpp

View Options

src/test/random_tests.cpp

View Options

src/test/rcu_tests.cpp

View Options

src/test/reverselock_tests.cpp

View Options

src/test/rpc_server_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/rwcollection_tests.cpp

View Options

src/test/sanity_tests.cpp

View Options

src/test/scheduler_tests.cpp

View Options

src/test/schnorr_tests.cpp

View Options

src/test/script_bitfield_tests.cpp

View Options

src/test/script_commitment_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/script_standard_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/scriptnum_tests.cpp

View Options

src/test/serialize_tests.cpp

View Options

src/test/setup_common.h

View Options

src/test/setup_common.cpp

View Options

src/test/sigcache_tests.cpp

View Options

src/test/sigcheckcount_tests.cpp

View Options

src/test/sigencoding_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/sighashtype_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/streams_tests.cpp

View Options

src/test/sync_tests.cpp

View Options

src/test/test_bitcoin.h

View Options

src/test/test_bitcoin.cpp

View Options

src/test/timedata_tests.cpp

View Options

src/test/torcontrol_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txindex_tests.cpp

View Options

src/test/txvalidation_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/test/uint256_tests.cpp

View Options

src/test/undo_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/test/validation_tests.cpp

View Options

src/test/versionbits_tests.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

src/wallet/test/db_tests.cpp

View Options

src/wallet/test/init_test_fixture.h

View Options

src/wallet/test/init_tests.cpp

View Options

src/wallet/test/psbt_wallet_tests.cpp

View Options

src/wallet/test/wallet_crypto_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.h

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/test/walletdb_tests.cpp