Page MenuHomePhabricator

Fix linking in bitcoin-bench for Windows build
AbandonedPublic

Authored by jasonbcox on Thu, Mar 19, 23:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

libevent linking is missing

Test Plan

Cross-compile Windows
+ Run Windows Gitian build on CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-win-linking
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9901
Build 17661: Bitcoin ABC Buildbot
Build 17660: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Thu, Mar 19, 23:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 19, 23:35
deadalnix requested changes to this revision.Fri, Mar 20, 00:17
deadalnix added a subscriber: deadalnix.

This is obviously wrong. The fact that it happens to work doesn't make it right.

This revision now requires changes to proceed.Fri, Mar 20, 00:17
jasonbcox abandoned this revision.Fri, Mar 20, 01:10