Event requires lib ws2_32 on windows (as well as shell32 and advapi32).
The missing ws2_32 caused the bench to fail the build (shell32 and advapi32 are already added by other dependencies).
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING00952ad57a25: [CMAKE] Fix the bench build for windows
rABC00952ad57a25: [CMAKE] Fix the bench build for windows
Run the Gitian builds.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_fix_windows_bench
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 9904 Build 17667: Default Diff Build & Tests Build 17666: arc lint + arc unit
Event Timeline
Comment Actions
Because it's not enough, unfortunately. Not only event needs it, but also util for system.cpp:SetupNetworking().
I started to work on a better solution, but a complete fix requires to backport all the wallet/server separation first, which we should do but it's huge.
This fix is simpl and more in line with autotools (which is unaffected). If it is a no-go then I will revert the faulty commit.
Comment Actions
If libevent needs ws2_32 on some plateform, then it needs it on some plateforms. This needs to be part of the fix. I don't see how any backport changes this.
Comment Actions
For some reason I was focusing on removing the dependency to util at the same time, and that needs to pull more code. Just add adding the event dependency will work for sure.
| cmake/modules/FindEvent.cmake | ||
|---|---|---|
| 53 ↗ | (On Diff #17074) | Note to reviewers: no need to use a find_library here since they are part of the windows SDK. |