Page MenuHomePhabricator

build: macOS toolchain update
ClosedPublic

Authored by Fabien on Sat, Mar 21, 12:12.

Details

Summary
TLDR: This updates our macOS toolchain to use a newer version of Clang,
cctools (including new dependency on libtapi), LD64 and the macOS SDK.

I've been testing depends builds (HOST=x86_64-apple-darwin16) inside a
Debian Buster Docker container, and running the resultant bitcoind and
bitcoin-qt binaries on a macOS 10.14.4 system. The .dmg generated by a
make deploy also mounts correctly on the same macOS system.
Clang

Upgraded from 3.7.1 to 6.0.1
cctools

    cctools 877.8 -> 921
    LD64 253.9 -> 409.12
    TAPI 1000.10.8

See tpoechtrager/cctools-port and tpoechtrager/apple-libtapi.
macOS SDK

Upgraded from building against the macOS 10.11 SDK to the macOS 10.14
SDK.

Backport of core PR16392.

Depends on D5530.

Test Plan

Run the OSX Gitian build twice and check it is deterministic.
Run the app on OSX (10.12 and 10.15) and check it runs.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sat, Mar 21, 12:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Mar 21, 12:12
teamcity edited the summary of this revision. (Show Details)Sat, Mar 21, 12:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Snippet of first build failure:

[12:27:27] :	 [Step 1/1] (Reading database ... 80%
[12:27:27] :	 [Step 1/1] (Reading database ... 85%
[12:27:27] :	 [Step 1/1] (Reading database ... 90%
[12:27:27] :	 [Step 1/1] (Reading database ... 95%
[12:27:27] :	 [Step 1/1] (Reading database ... 100%
[12:27:27] :	 [Step 1/1] (Reading database ... 17687 files and directories currently installed.)
[12:27:27] :	 [Step 1/1] Removing rsyslog (8.1901.0-1) ...
[12:27:27] :	 [Step 1/1] invoke-rc.d: could not determine current runlevel
[12:27:27] :	 [Step 1/1] Stopping enhanced syslogd: rsyslogd already stopped.
[12:27:28] :	 [Step 1/1] (Reading database ... 
[12:27:28] :	 [Step 1/1] (Reading database ... 5%
[12:27:28] :	 [Step 1/1] (Reading database ... 10%
[12:27:28] :	 [Step 1/1] (Reading database ... 15%
[12:27:28] :	 [Step 1/1] (Reading database ... 20%
[12:27:28] :	 [Step 1/1] (Reading database ... 25%
[12:27:28] :	 [Step 1/1] (Reading database ... 30%
[12:27:28] :	 [Step 1/1] (Reading database ... 35%
[12:27:28] :	 [Step 1/1] (Reading database ... 40%
[12:27:28] :	 [Step 1/1] (Reading database ... 45%
[12:27:28] :	 [Step 1/1] (Reading database ... 50%
[12:27:28] :	 [Step 1/1] (Reading database ... 55%
[12:27:28] :	 [Step 1/1] (Reading database ... 60%
[12:27:28] :	 [Step 1/1] (Reading database ... 65%
[12:27:28] :	 [Step 1/1] (Reading database ... 70%
[12:27:28] :	 [Step 1/1] (Reading database ... 75%
[12:27:28] :	 [Step 1/1] (Reading database ... 80%
[12:27:28] :	 [Step 1/1] (Reading database ... 85%
[12:27:28] :	 [Step 1/1] (Reading database ... 90%
[12:27:28] :	 [Step 1/1] (Reading database ... 95%
[12:27:28] :	 [Step 1/1] (Reading database ... 100%
[12:27:28] :	 [Step 1/1] (Reading database ... 17629 files and directories currently installed.)
[12:27:28] :	 [Step 1/1] Purging configuration files for rsyslog (8.1901.0-1) ...
[12:27:28] :	 [Step 1/1] Processing triggers for systemd (241-7~deb10u1) ...
[12:27:28] :	 [Step 1/1] Adding 'local diversion of /sbin/initctl to /sbin/initctl.distrib'
[12:27:28] :	 [Step 1/1] Adding 'local diversion of /usr/bin/ischroot to /usr/bin/ischroot.distrib'
[12:27:28]W:	 [Step 1/1] dpkg-divert: warning: diverting file '/usr/bin/ischroot' from an Essential package with rename is dangerous, use --no-rename
[12:27:28] :	 [Step 1/1] Adding 'local diversion of /usr/sbin/policy-rc.d to /usr/sbin/policy-rc.d.distrib'
[12:27:28] :	 [Step 1/1] Starting target
[12:27:28] :	 [Step 1/1] Checking if target is up
[12:27:29] :	 [Step 1/1] Preparing build environment
[12:27:29]W:	 [Step 1/1] tar: MacOSX10.14.sdk.tar.gz: Cannot stat: No such file or directory
[12:27:29]W:	 [Step 1/1] tar: Exiting with failure status due to previous errors
[12:27:32] :	 [Step 1/1] Updating apt-get repository (log in var/install.log)
[12:27:36] :	 [Step 1/1] Installing additional packages (log in var/install.log)
[12:28:41] :	 [Step 1/1] Upgrading system, may take a while (log in var/install.log)
[12:28:50] :	 [Step 1/1] Creating package manifest
[12:28:54] :	 [Step 1/1] Creating build script (var/build-script)
[12:28:56] :	 [Step 1/1] Running build script (log in var/build.log)
[12:28:57]W:	 [Step 1/1] ./bin/gbuild:21:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
[12:28:57]W:	 [Step 1/1] 	from ./bin/gbuild:167:in `build_one_configuration'
[12:28:57]W:	 [Step 1/1] 	from ./bin/gbuild:318:in `block (2 levels) in <main>'
[12:28:57]W:	 [Step 1/1] 	from ./bin/gbuild:313:in `each'
[12:28:57]W:	 [Step 1/1] 	from ./bin/gbuild:313:in `block in <main>'
[12:28:57]W:	 [Step 1/1] 	from ./bin/gbuild:311:in `each'
[12:28:57]W:	 [Step 1/1] 	from ./bin/gbuild:311:in `<main>'
[12:28:57]W:	 [Step 1/1] ++ move_log
[12:28:57]W:	 [Step 1/1] ++ mv var/install.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[12:28:57]W:	 [Step 1/1] ++ mv var/build.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[12:28:57]W:	 [Step 1/1] Process exited with code 1
[12:28:57]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)

Snippet of first build failure:

[12:27:33] :	 [Step 1/1] (Reading database ... 80%
[12:27:33] :	 [Step 1/1] (Reading database ... 85%
[12:27:33] :	 [Step 1/1] (Reading database ... 90%
[12:27:33] :	 [Step 1/1] (Reading database ... 95%
[12:27:33] :	 [Step 1/1] (Reading database ... 100%
[12:27:33] :	 [Step 1/1] (Reading database ... 17687 files and directories currently installed.)
[12:27:33] :	 [Step 1/1] Removing rsyslog (8.1901.0-1) ...
[12:27:33] :	 [Step 1/1] invoke-rc.d: could not determine current runlevel
[12:27:33] :	 [Step 1/1] Stopping enhanced syslogd: rsyslogd already stopped.
[12:27:33] :	 [Step 1/1] (Reading database ... 
[12:27:33] :	 [Step 1/1] (Reading database ... 5%
[12:27:33] :	 [Step 1/1] (Reading database ... 10%
[12:27:33] :	 [Step 1/1] (Reading database ... 15%
[12:27:33] :	 [Step 1/1] (Reading database ... 20%
[12:27:33] :	 [Step 1/1] (Reading database ... 25%
[12:27:33] :	 [Step 1/1] (Reading database ... 30%
[12:27:33] :	 [Step 1/1] (Reading database ... 35%
[12:27:33] :	 [Step 1/1] (Reading database ... 40%
[12:27:33] :	 [Step 1/1] (Reading database ... 45%
[12:27:33] :	 [Step 1/1] (Reading database ... 50%
[12:27:33] :	 [Step 1/1] (Reading database ... 55%
[12:27:33] :	 [Step 1/1] (Reading database ... 60%
[12:27:33] :	 [Step 1/1] (Reading database ... 65%
[12:27:33] :	 [Step 1/1] (Reading database ... 70%
[12:27:33] :	 [Step 1/1] (Reading database ... 75%
[12:27:33] :	 [Step 1/1] (Reading database ... 80%
[12:27:33] :	 [Step 1/1] (Reading database ... 85%
[12:27:33] :	 [Step 1/1] (Reading database ... 90%
[12:27:33] :	 [Step 1/1] (Reading database ... 95%
[12:27:33] :	 [Step 1/1] (Reading database ... 100%
[12:27:33] :	 [Step 1/1] (Reading database ... 17629 files and directories currently installed.)
[12:27:33] :	 [Step 1/1] Purging configuration files for rsyslog (8.1901.0-1) ...
[12:27:33] :	 [Step 1/1] Processing triggers for systemd (241-7~deb10u1) ...
[12:27:33] :	 [Step 1/1] Adding 'local diversion of /sbin/initctl to /sbin/initctl.distrib'
[12:27:33] :	 [Step 1/1] Adding 'local diversion of /usr/bin/ischroot to /usr/bin/ischroot.distrib'
[12:27:33]W:	 [Step 1/1] dpkg-divert: warning: diverting file '/usr/bin/ischroot' from an Essential package with rename is dangerous, use --no-rename
[12:27:33] :	 [Step 1/1] Adding 'local diversion of /usr/sbin/policy-rc.d to /usr/sbin/policy-rc.d.distrib'
[12:27:33] :	 [Step 1/1] Starting target
[12:27:34] :	 [Step 1/1] Checking if target is up
[12:27:34] :	 [Step 1/1] Preparing build environment
[12:27:35]W:	 [Step 1/1] tar: MacOSX10.14.sdk.tar.gz: Cannot stat: No such file or directory
[12:27:35]W:	 [Step 1/1] tar: Exiting with failure status due to previous errors
[12:27:37] :	 [Step 1/1] Updating apt-get repository (log in var/install.log)
[12:27:41] :	 [Step 1/1] Installing additional packages (log in var/install.log)
[12:28:45] :	 [Step 1/1] Upgrading system, may take a while (log in var/install.log)
[12:28:54] :	 [Step 1/1] Creating package manifest
[12:28:58] :	 [Step 1/1] Creating build script (var/build-script)
[12:28:59] :	 [Step 1/1] Running build script (log in var/build.log)
[12:28:59]W:	 [Step 1/1] ./bin/gbuild:21:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
[12:28:59]W:	 [Step 1/1] 	from ./bin/gbuild:167:in `build_one_configuration'
[12:28:59]W:	 [Step 1/1] 	from ./bin/gbuild:318:in `block (2 levels) in <main>'
[12:28:59]W:	 [Step 1/1] 	from ./bin/gbuild:313:in `each'
[12:28:59]W:	 [Step 1/1] 	from ./bin/gbuild:313:in `block in <main>'
[12:28:59]W:	 [Step 1/1] 	from ./bin/gbuild:311:in `each'
[12:28:59]W:	 [Step 1/1] 	from ./bin/gbuild:311:in `<main>'
[12:28:59]W:	 [Step 1/1] ++ move_log
[12:28:59]W:	 [Step 1/1] ++ mv var/install.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[12:28:59]W:	 [Step 1/1] ++ mv var/build.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[12:28:59]W:	 [Step 1/1] Process exited with code 1
[12:28:59]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
Fabien planned changes to this revision.Sat, Mar 21, 12:30
Fabien updated this revision to Diff 17095.Sat, Mar 21, 12:46
Fabien edited the summary of this revision. (Show Details)

Rebase on top of D5532.

Snippet of first build failure:

[12:47:59]W:	 [Step 1/1]  52350K .......... .......... .......... .......... .......... 96%  261M 0s
[12:47:59]W:	 [Step 1/1]  52400K .......... .......... .......... .......... .......... 96%  254M 0s
[12:47:59]W:	 [Step 1/1]  52450K .......... .......... .......... .......... .......... 96%  316M 0s
[12:47:59]W:	 [Step 1/1]  52500K .......... .......... .......... .......... .......... 96%  150M 0s
[12:47:59]W:	 [Step 1/1]  52550K .......... .......... .......... .......... .......... 96%  276M 0s
[12:47:59]W:	 [Step 1/1]  52600K .......... .......... .......... .......... .......... 97%  367M 0s
[12:47:59]W:	 [Step 1/1]  52650K .......... .......... .......... .......... .......... 97%  177M 0s
[12:47:59]W:	 [Step 1/1]  52700K .......... .......... .......... .......... .......... 97%  134M 0s
[12:47:59]W:	 [Step 1/1]  52750K .......... .......... .......... .......... .......... 97%  194M 0s
[12:47:59]W:	 [Step 1/1]  52800K .......... .......... .......... .......... .......... 97%  248M 0s
[12:47:59]W:	 [Step 1/1]  52850K .......... .......... .......... .......... .......... 97%  420M 0s
[12:47:59]W:	 [Step 1/1]  52900K .......... .......... .......... .......... .......... 97%  137M 0s
[12:47:59]W:	 [Step 1/1]  52950K .......... .......... .......... .......... .......... 97%  210M 0s
[12:47:59]W:	 [Step 1/1]  53000K .......... .......... .......... .......... .......... 97%  104M 0s
[12:47:59]W:	 [Step 1/1]  53050K .......... .......... .......... .......... .......... 97%  365M 0s
[12:47:59]W:	 [Step 1/1]  53100K .......... .......... .......... .......... .......... 97%  536M 0s
[12:47:59]W:	 [Step 1/1]  53150K .......... .......... .......... .......... .......... 98%  191M 0s
[12:47:59]W:	 [Step 1/1]  53200K .......... .......... .......... .......... .......... 98%  187M 0s
[12:47:59]W:	 [Step 1/1]  53250K .......... .......... .......... .......... .......... 98%  219M 0s
[12:47:59]W:	 [Step 1/1]  53300K .......... .......... .......... .......... .......... 98%  355M 0s
[12:47:59]W:	 [Step 1/1]  53350K .......... .......... .......... .......... .......... 98%  174M 0s
[12:47:59]W:	 [Step 1/1]  53400K .......... .......... .......... .......... .......... 98%  175M 0s
[12:47:59]W:	 [Step 1/1]  53450K .......... .......... .......... .......... .......... 98%  192M 0s
[12:47:59]W:	 [Step 1/1]  53500K .......... .......... .......... .......... .......... 98%  432M 0s
[12:47:59]W:	 [Step 1/1]  53550K .......... .......... .......... .......... .......... 98%  178M 0s
[12:47:59]W:	 [Step 1/1]  53600K .......... .......... .......... .......... .......... 98%  110M 0s
[12:47:59]W:	 [Step 1/1]  53650K .......... .......... .......... .......... .......... 98%  251M 0s
[12:47:59]W:	 [Step 1/1]  53700K .......... .......... .......... .......... .......... 99%  272M 0s
[12:47:59]W:	 [Step 1/1]  53750K .......... .......... .......... .......... .......... 99%  393M 0s
[12:47:59]W:	 [Step 1/1]  53800K .......... .......... .......... .......... .......... 99%  107M 0s
[12:47:59]W:	 [Step 1/1]  53850K .......... .......... .......... .......... .......... 99%  282M 0s
[12:47:59]W:	 [Step 1/1]  53900K .......... .......... .......... .......... .......... 99%  178M 0s
[12:47:59]W:	 [Step 1/1]  53950K .......... .......... .......... .......... .......... 99%  528M 0s
[12:47:59]W:	 [Step 1/1]  54000K .......... .......... .......... .......... .......... 99%  205M 0s
[12:47:59]W:	 [Step 1/1]  54050K .......... .......... .......... .......... .......... 99%  165M 0s
[12:47:59]W:	 [Step 1/1]  54100K .......... .......... .......... .......... .......... 99%  179M 0s
[12:47:59]W:	 [Step 1/1]  54150K .......... .......... .......... .......... .......... 99%  171M 0s
[12:47:59]W:	 [Step 1/1]  54200K .......... .......... .......... .......... .......... 99%  468M 0s
[12:47:59]W:	 [Step 1/1]  54250K ..........                                            100% 91.2M=0.4s
[12:47:59]W:	 [Step 1/1] 
[12:47:59]W:	 [Step 1/1] 2020-03-21 12:47:59 (133 MB/s) - 'MacOSX10.14.sdk.tar.gz' saved [55563080/55563080]
[12:47:59]W:	 [Step 1/1] 
[12:47:59]W:	 [Step 1/1] + echo '2322086a96349db832abbcadea493b79db843553a2e604163238d99fa058a286  MacOSX10.14.sdk.tar.gz'
[12:47:59]W:	 [Step 1/1] + sha256sum -c
[12:47:59]W:	 [Step 1/1] + popd
[12:47:59] :	 [Step 1/1] MacOSX10.14.sdk.tar.gz: OK
[12:47:59]W:	 [Step 1/1] ++ nproc
[12:47:59] :	 [Step 1/1] ~/buildAgent/work/c4a5708f2bae7929/contrib/teamcity
[12:47:59]W:	 [Step 1/1] + THREADS=12
[12:47:59]W:	 [Step 1/1] + RESULT_DIR=/home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results
[12:47:59]W:	 [Step 1/1] + OS_DIR=/home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/osx
[12:47:59]W:	 [Step 1/1] + mkdir -p /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/osx
[12:47:59]W:	 [Step 1/1] + trap move_log ERR
[12:47:59]W:	 [Step 1/1] + ./bin/gbuild -j12 -m3500 --commit bitcoin=f427ea0abcf1ddb50ab6d95202c52ddcee2caf91 --url bitcoin=/home/teamcity/buildAgent/work/c4a5708f2bae7929 /home/teamcity/buildAgent/work/c4a5708f2bae7929/contrib/gitian-descriptors/gitian-osx.yml
[12:47:59]W:	 [Step 1/1] ./contrib/teamcity/gitian.sh: line 46: ./bin/gbuild: No such file or directory
[12:47:59]W:	 [Step 1/1] ++ move_log
[12:47:59]W:	 [Step 1/1] ++ mv var/install.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[12:47:59]W:	 [Step 1/1] mv: cannot stat 'var/install.log': No such file or directory
[12:47:59]W:	 [Step 1/1] Process exited with code 1
[12:48:00]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)

Snippet of first build failure:

[12:48:16]W:	 [Step 1/1]  52350K .......... .......... .......... .......... .......... 96%  321M 0s
[12:48:16]W:	 [Step 1/1]  52400K .......... .......... .......... .......... .......... 96%  233M 0s
[12:48:16]W:	 [Step 1/1]  52450K .......... .......... .......... .......... .......... 96%  228M 0s
[12:48:16]W:	 [Step 1/1]  52500K .......... .......... .......... .......... .......... 96%  136M 0s
[12:48:16]W:	 [Step 1/1]  52550K .......... .......... .......... .......... .......... 96% 55.7M 0s
[12:48:16]W:	 [Step 1/1]  52600K .......... .......... .......... .......... .......... 97%  468M 0s
[12:48:16]W:	 [Step 1/1]  52650K .......... .......... .......... .......... .......... 97%  138M 0s
[12:48:16]W:	 [Step 1/1]  52700K .......... .......... .......... .......... .......... 97%  532M 0s
[12:48:16]W:	 [Step 1/1]  52750K .......... .......... .......... .......... .......... 97%  585M 0s
[12:48:16]W:	 [Step 1/1]  52800K .......... .......... .......... .......... .......... 97%  161M 0s
[12:48:16]W:	 [Step 1/1]  52850K .......... .......... .......... .......... .......... 97%  353M 0s
[12:48:16]W:	 [Step 1/1]  52900K .......... .......... .......... .......... .......... 97%  446M 0s
[12:48:16]W:	 [Step 1/1]  52950K .......... .......... .......... .......... .......... 97%  311M 0s
[12:48:16]W:	 [Step 1/1]  53000K .......... .......... .......... .......... .......... 97%  111M 0s
[12:48:16]W:	 [Step 1/1]  53050K .......... .......... .......... .......... .......... 97%  571M 0s
[12:48:16]W:	 [Step 1/1]  53100K .......... .......... .......... .......... .......... 97%  234M 0s
[12:48:16]W:	 [Step 1/1]  53150K .......... .......... .......... .......... .......... 98% 96.6M 0s
[12:48:16]W:	 [Step 1/1]  53200K .......... .......... .......... .......... .......... 98%  272M 0s
[12:48:16]W:	 [Step 1/1]  53250K .......... .......... .......... .......... .......... 98%  518M 0s
[12:48:16]W:	 [Step 1/1]  53300K .......... .......... .......... .......... .......... 98%  355M 0s
[12:48:16]W:	 [Step 1/1]  53350K .......... .......... .......... .......... .......... 98%  197M 0s
[12:48:16]W:	 [Step 1/1]  53400K .......... .......... .......... .......... .......... 98%  279M 0s
[12:48:16]W:	 [Step 1/1]  53450K .......... .......... .......... .......... .......... 98%  172M 0s
[12:48:16]W:	 [Step 1/1]  53500K .......... .......... .......... .......... .......... 98%  215M 0s
[12:48:16]W:	 [Step 1/1]  53550K .......... .......... .......... .......... .......... 98%  227M 0s
[12:48:16]W:	 [Step 1/1]  53600K .......... .......... .......... .......... .......... 98%  136M 0s
[12:48:16]W:	 [Step 1/1]  53650K .......... .......... .......... .......... .......... 98%  533M 0s
[12:48:16]W:	 [Step 1/1]  53700K .......... .......... .......... .......... .......... 99%  240M 0s
[12:48:16]W:	 [Step 1/1]  53750K .......... .......... .......... .......... .......... 99%  181M 0s
[12:48:16]W:	 [Step 1/1]  53800K .......... .......... .......... .......... .......... 99%  188M 0s
[12:48:16]W:	 [Step 1/1]  53850K .......... .......... .......... .......... .......... 99%  132M 0s
[12:48:16]W:	 [Step 1/1]  53900K .......... .......... .......... .......... .......... 99%  339M 0s
[12:48:16]W:	 [Step 1/1]  53950K .......... .......... .......... .......... .......... 99%  214M 0s
[12:48:16]W:	 [Step 1/1]  54000K .......... .......... .......... .......... .......... 99%  114M 0s
[12:48:16]W:	 [Step 1/1]  54050K .......... .......... .......... .......... .......... 99%  265M 0s
[12:48:16]W:	 [Step 1/1]  54100K .......... .......... .......... .......... .......... 99%  141M 0s
[12:48:16]W:	 [Step 1/1]  54150K .......... .......... .......... .......... .......... 99%  137M 0s
[12:48:16]W:	 [Step 1/1]  54200K .......... .......... .......... .......... .......... 99%  358M 0s
[12:48:16]W:	 [Step 1/1]  54250K ..........                                            100%  615M=1.0s
[12:48:16]W:	 [Step 1/1] 
[12:48:16]W:	 [Step 1/1] 2020-03-21 12:48:16 (53.7 MB/s) - 'MacOSX10.14.sdk.tar.gz' saved [55563080/55563080]
[12:48:16]W:	 [Step 1/1] 
[12:48:16]W:	 [Step 1/1] + echo '2322086a96349db832abbcadea493b79db843553a2e604163238d99fa058a286  MacOSX10.14.sdk.tar.gz'
[12:48:16]W:	 [Step 1/1] + sha256sum -c
[12:48:16] :	 [Step 1/1] MacOSX10.14.sdk.tar.gz: OK
[12:48:16] :	 [Step 1/1] ~/buildAgent/work/c4a5708f2bae7929/contrib/teamcity
[12:48:16]W:	 [Step 1/1] + popd
[12:48:16]W:	 [Step 1/1] ++ nproc
[12:48:16]W:	 [Step 1/1] + THREADS=12
[12:48:16]W:	 [Step 1/1] + RESULT_DIR=/home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results
[12:48:16]W:	 [Step 1/1] + OS_DIR=/home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/osx
[12:48:16]W:	 [Step 1/1] + mkdir -p /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/osx
[12:48:16]W:	 [Step 1/1] + trap move_log ERR
[12:48:16]W:	 [Step 1/1] + ./bin/gbuild -j12 -m3500 --commit bitcoin=f427ea0abcf1ddb50ab6d95202c52ddcee2caf91 --url bitcoin=/home/teamcity/buildAgent/work/c4a5708f2bae7929 /home/teamcity/buildAgent/work/c4a5708f2bae7929/contrib/gitian-descriptors/gitian-osx.yml
[12:48:16]W:	 [Step 1/1] ./contrib/teamcity/gitian.sh: line 46: ./bin/gbuild: No such file or directory
[12:48:16]W:	 [Step 1/1] ++ move_log
[12:48:16]W:	 [Step 1/1] ++ mv var/install.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[12:48:17]W:	 [Step 1/1] mv: cannot stat 'var/install.log': No such file or directory
[12:48:17]W:	 [Step 1/1] Process exited with code 1
[12:48:18]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
Fabien updated this revision to Diff 17097.Sat, Mar 21, 12:54

Rebase.

deadalnix added inline comments.
doc/build-osx.md
198 ↗(On Diff #17097)

There was a recent patch to move these notes here, why move them back?

Fabien added inline comments.Sat, Mar 21, 14:38
doc/build-osx.md
198 ↗(On Diff #17097)

Good catch. This is what happened in core also. I could have made a single diff with both PRs but I was afraid that made it more difficult to review, hence the close to each other moves.

Fabien added inline comments.Sat, Mar 21, 14:41
doc/build-osx.md
198 ↗(On Diff #17097)

Ah also it's not moved back, it's another new place. README_osx => build-osx => macdeploy/README

deadalnix accepted this revision.Wed, Mar 25, 23:48
This revision is now accepted and ready to land.Wed, Mar 25, 23:48
This revision was automatically updated to reflect the committed changes.