Page MenuHomePhabricator
Differential D5539

utils: Add fstream wrapper to allow to pass unicode filename on Windows
ClosedPublic
Actions

Authored by Fabien on Mar 23 2020, 10:47.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING52d310b4a28b: utils: Add fstream wrapper to allow to pass unicode filename on Windows
rABC52d310b4a28b: utils: Add fstream wrapper to allow to pass unicode filename on Windows
Summary
If compiled with mingw, use glibc++ extension stdio_filebuf to open the
file by FILE* instead of filename.

In other condition, we can use boost::fstream.

Backport of core PR13878 and PR15468 (related bug fix).

Depends on D5539.

Test Plan
ninja check
make check

Run the Gitian builds.

Build and run for Windows. Run test_bitcoin on Windows.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 23 2020, 10:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2020, 10:47
teamcity edited the summary of this revision. (Show Details)Mar 23 2020, 10:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 23 2020, 10:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 23 2020, 10:48

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.Mar 23 2020, 10:56

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

teamcity added a comment.Mar 23 2020, 10:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9929: Diff 17111.Mar 23 2020, 11:00
jasonbcox accepted this revision.Mar 23 2020, 22:05
This revision is now accepted and ready to land.Mar 23 2020, 22:05
Closed by commit rABC52d310b4a28b: utils: Add fstream wrapper to allow to pass unicode filename on Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyMar 24 2020, 09:35
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC52d310b4a28b: utils: Add fstream wrapper to allow to pass unicode filename on Windows.
Fabien added a commit: rSTAGING52d310b4a28b: utils: Add fstream wrapper to allow to pass unicode filename on Windows.Apr 7 2020, 23:26

Revision Contents
Changeset List

PathSize
src/
1 line
60 lines
103 lines
qt/
8 lines
rpc/
9 lines
test/
1 line
59 lines
util/
4 lines
wallet/
10 lines
2 lines

Diff 17135

View Options

src/Makefile.test.include

Loading...
View Options

src/fs.h

Loading...
View Options

src/fs.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/rpc/protocol.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/fs_tests.cpp

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/walletutil.cpp

Loading...