Page MenuHomePhabricator

[SECP256K1] Turn off ASM by default on target with no ASM support
ClosedPublic

Authored by Fabien on Mar 27 2020, 15:03.

Details

Summary

This will drop the need to set -DSECP256K1_USE_ASM=OFF for targets
with no support for ASM in secp256k1.

Test Plan

Run cmake on various platforms and check the ASM is enabled/disabled as
needed.

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/secp256k1/CMakeLists.txt
82 ↗(On Diff #17245)

The docstring is wrong.

This revision is now accepted and ready to land.Mar 27 2020, 15:09

Remove obsolete if available from docstring.