Page MenuHomePhabricator
Differential D5590

[SECP256K1] Turn off ASM by default on target with no ASM support
ClosedPublic
Actions

Authored by Fabien on Mar 27 2020, 15:03.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe32abdcf10e9: [SECP256K1] Turn off ASM by default on target with no ASM support
rABCe32abdcf10e9: [SECP256K1] Turn off ASM by default on target with no ASM support
Summary

This will drop the need to set -DSECP256K1_USE_ASM=OFF for targets
with no support for ASM in secp256k1.

Test Plan

Run cmake on various platforms and check the ASM is enabled/disabled as
needed.

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_asm_better_ux
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10012
Build 17870: Default Diff Build & Tests
Build 17869: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 27 2020, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2020, 15:03
teamcity added a comment.Mar 27 2020, 15:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 27 2020, 15:04

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

teamcity added a comment.Mar 27 2020, 15:04

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.Mar 27 2020, 15:05

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.Mar 27 2020, 15:08

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

deadalnix accepted this revision.Mar 27 2020, 15:09
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/secp256k1/CMakeLists.txt
82 ↗(On Diff #17245)

The docstring is wrong.

This revision is now accepted and ready to land.Mar 27 2020, 15:09
teamcity added a comment.Mar 27 2020, 15:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10010: Diff 17245.Mar 27 2020, 15:13
teamcity added a comment.Mar 27 2020, 15:13

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

Fabien updated this revision to Diff 17246.Mar 27 2020, 15:18

Remove obsolete if available from docstring.

teamcity added a comment.Mar 27 2020, 15:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10012: Diff 17246.Mar 27 2020, 15:28
teamcity added a comment.Mar 27 2020, 15:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

teamcity added a comment.Mar 27 2020, 15:31

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Closed by commit rABCe32abdcf10e9: [SECP256K1] Turn off ASM by default on target with no ASM support (authored by Fabien). · Explain WhyMar 27 2020, 15:35
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe32abdcf10e9: [SECP256K1] Turn off ASM by default on target with no ASM support.
Fabien added a commit: rSTAGINGe32abdcf10e9: [SECP256K1] Turn off ASM by default on target with no ASM support.Apr 7 2020, 23:30

Revision Contents
Changeset List

PathSize
contrib/
gitian-descriptors/
2 lines
2 lines
src/
secp256k1/
28 lines

Diff 17246

View Options

contrib/gitian-descriptors/gitian-linux.yml

Loading...
View Options

contrib/gitian-descriptors/gitian-win.yml

Loading...
View Options

src/secp256k1/CMakeLists.txt

Loading...