[SECP256K1] Travis Don't run the constant time check with java tests
ClosedPublic
Actions

Authored by Fabien on Mar 30 2020, 08:15.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGcb0260b37347: [SECP256K1] Travis Don't run the constant time check with java tests
rABCcb0260b37347: [SECP256K1] Travis Don't run the constant time check with java tests

Summary

The autotools check-java target doesn't build the
valgrind_ctime_test, causing Travis to fail.
Since the case (without JNI) it already covered, it is safe to disable
the check for this case.

Test Plan

Run the Travis build (see
https://travis-ci.org/github/Fabcien/secp256k1/builds/668626198).

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 30 2020, 08:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 08:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10023: Diff 17268.Mar 30 2020, 08:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix accepted this revision.Mar 30 2020, 14:05

This revision is now accepted and ready to land.Mar 30 2020, 14:05

Closed by commit rABCcb0260b37347: [SECP256K1] Travis Don't run the constant time check with java tests (authored by Fabien). · Explain WhyMar 31 2020, 12:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcb0260b37347: [SECP256K1] Travis Don't run the constant time check with java tests.

Fabien added a commit: rSTAGINGcb0260b37347: [SECP256K1] Travis Don't run the constant time check with java tests.Apr 7 2020, 23:31

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

.travis.yml

2 lines

Diff 17302

View Options

[SECP256K1] Travis Don't run the constant time check with java testsClosedPublicActions