Page MenuHomePhabricator

[DOC] Add checking the secp256k1 Travis build to the release process
Needs RevisionPublic

Authored by Fabien on Mar 30 2020, 16:28.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Summary

As per title.

Test Plan

Read the doc and ensure the link works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_travis_release_process
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10043
Build 17924: Default Diff Build & Tests
Build 17923: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 30 2020, 16:33
deadalnix requested changes to this revision.Mar 30 2020, 16:35
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
doc/release-process.md
18 ↗(On Diff #17283)

No, this needs to be checked for the specific commit that will be tagged, not for master.

This revision now requires changes to proceed.Mar 30 2020, 16:35
Fabien requested review of this revision.Mar 30 2020, 19:03
Fabien added inline comments.
doc/release-process.md
18 ↗(On Diff #17283)

If you follow the flow of the document, you want to check the tests are green (pt. 2), then update the documents as needed (pt. 3), than tag the commit (pt. 4), so at this point it's still master.

doc/release-process.md
18 ↗(On Diff #17283)

https://travis-ci.org/github/Bitcoin-ABC/secp256k1/builds provides a cleaner view into builds by commit. Perhaps this is a more accurate link. While HEAD of master is likely to be the release candidate, that isn't always the case. The current link doesn't make it obvious which job is which unless you drill down.

doc/release-process.md
18 ↗(On Diff #17283)

Sure but it's only daily. It may not be the same commit than the one that'll be tagged.

deadalnix requested changes to this revision.Mar 31 2020, 20:51
This revision now requires changes to proceed.Mar 31 2020, 20:51