Page MenuHomePhabricator
Differential D5613

Clean the native directory when using the clean target
ClosedPublic
Actions

Authored by deadalnix on Mar 30 2020, 17:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5a74bd17d75c: Clean the native directory when using the clean target
rABC5a74bd17d75c: Clean the native directory when using the clean target
Summary

As per title. The native directory is defintively a build byproduct.

Test Plan
ninja clean

Check that the native folder is gone.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Mar 30 2020, 17:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 17:03
teamcity added a comment.Mar 30 2020, 17:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 30 2020, 17:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10039: Diff 17286.Mar 30 2020, 17:13
Fabien requested changes to this revision.Mar 30 2020, 19:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cmake/modules/NativeExecutable.cmake
110 ↗(On Diff #17286)

This property has been added in 3.15, but we enforce 3.13 (Debian buster uses 3.13).

This revision now requires changes to proceed.Mar 30 2020, 19:50
deadalnix requested review of this revision.Mar 30 2020, 23:06
deadalnix added inline comments.
cmake/modules/NativeExecutable.cmake
110 ↗(On Diff #17286)

It does nothing for older version, which is exactly what we do now. I don't see how this is a problem.

Fabien accepted this revision.Mar 31 2020, 08:03
Fabien added inline comments.
cmake/modules/NativeExecutable.cmake
110 ↗(On Diff #17286)

OK I expected it to fail, not to ignore. Just tested and no issue.

This revision is now accepted and ready to land.Mar 31 2020, 08:03
Closed by commit rABC5a74bd17d75c: Clean the native directory when using the clean target (authored by deadalnix). · Explain WhyMar 31 2020, 12:07
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC5a74bd17d75c: Clean the native directory when using the clean target.
deadalnix added a commit: rSTAGING5a74bd17d75c: Clean the native directory when using the clean target.Apr 7 2020, 23:31

Revision Contents
Changeset List

PathSize
cmake/
modules/
3 lines

Diff 17304

View Options

cmake/modules/NativeExecutable.cmake

Loading...