Page MenuHomePhabricator

Clean the native directory when using the clean target
ClosedPublic

Authored by deadalnix on Mar 30 2020, 17:03.

Details

Summary

As per title. The native directory is defintively a build byproduct.

Test Plan
ninja clean

Check that the native folder is gone.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Mar 30 2020, 19:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cmake/modules/NativeExecutable.cmake
110 ↗(On Diff #17286)

This property has been added in 3.15, but we enforce 3.13 (Debian buster uses 3.13).

This revision now requires changes to proceed.Mar 30 2020, 19:50
deadalnix added inline comments.
cmake/modules/NativeExecutable.cmake
110 ↗(On Diff #17286)

It does nothing for older version, which is exactly what we do now. I don't see how this is a problem.

Fabien added inline comments.
cmake/modules/NativeExecutable.cmake
110 ↗(On Diff #17286)

OK I expected it to fail, not to ignore. Just tested and no issue.

This revision is now accepted and ready to land.Mar 31 2020, 08:03