Add version number to the seeder
ClosedPublic
Actions

Authored by nakihito on Mar 30 2020, 23:04.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGeadcc3e772d6: Add version number to the seeder
rABCeadcc3e772d6: Add version number to the seeder

Summary

The seeder does not currently have a version number. This will make it
easier to direct users to upgrade.

Test Plan

ninja
./bitcoin-seeder --version

Verify the output is as follows (or similar if version changes before this lands):

Bitcoin ABC Seeder v0.21.4-2436d3037
./bitcoin-seeder --help

Verify that the version output above appears before the rest of the help text.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 30 2020, 23:04

Owners added a reviewer: Restricted Owners Package.Mar 30 2020, 23:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 23:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10047: Diff 17298.Mar 30 2020, 23:14

Good call, but this needs to be consistent accross executables.

src/seeder/main.cpp
73 ↗	(On Diff #17298)	Yes keep that line even when showing help. See bitcoin-cli or bitcoin-tx for exemple.

This revision now requires changes to proceed.Mar 30 2020, 23:30

Fix to make more consistent across executables.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito edited the test plan for this revision. (Show Details)Mar 30 2020, 23:56

Harbormaster completed remote builds in B10048: Diff 17299.Mar 31 2020, 00:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix accepted this revision.Mar 31 2020, 13:57

This revision is now accepted and ready to land.Mar 31 2020, 13:57

Closed by commit rABCeadcc3e772d6: Add version number to the seeder (authored by nakihito). · Explain WhyMar 31 2020, 17:02

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABCeadcc3e772d6: Add version number to the seeder.

nakihito added a commit: rSTAGINGeadcc3e772d6: Add version number to the seeder.Apr 7 2020, 23:33

Revision Contents
Changeset List

Path

Size

src/

seeder/

main.cpp

16 lines

Diff 17326

View Options

Add version number to the seederClosedPublicActions