Page MenuHomePhabricator

Add version number to the seeder
ClosedPublic

Authored by nakihito on Mar 30 2020, 23:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGeadcc3e772d6: Add version number to the seeder
rABCeadcc3e772d6: Add version number to the seeder
Summary

The seeder does not currently have a version number. This will make it
easier to direct users to upgrade.

Test Plan
ninja
./bitcoin-seeder --version

Verify the output is as follows (or similar if version changes before this lands):

Bitcoin ABC Seeder v0.21.4-2436d3037
./bitcoin-seeder --help

Verify that the version output above appears before the rest of the help text.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
AddSeederVersion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10048
Build 17933: Default Diff Build & Tests
Build 17932: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 30 2020, 23:04
deadalnix requested changes to this revision.Mar 30 2020, 23:30
deadalnix added a subscriber: deadalnix.

Good call, but this needs to be consistent accross executables.

src/seeder/main.cpp
73 ↗(On Diff #17298)

Yes keep that line even when showing help. See bitcoin-cli or bitcoin-tx for exemple.

This revision now requires changes to proceed.Mar 30 2020, 23:30

Fix to make more consistent across executables.

This revision is now accepted and ready to land.Mar 31 2020, 13:57
This revision was automatically updated to reflect the committed changes.