The seeder does not currently have a version number. This will make it
easier to direct users to upgrade.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGINGeadcc3e772d6: Add version number to the seeder
rABCeadcc3e772d6: Add version number to the seeder
ninja ./bitcoin-seeder --version
Verify the output is as follows (or similar if version changes before this lands):
Bitcoin ABC Seeder v0.21.4-2436d3037 ./bitcoin-seeder --help
Verify that the version output above appears before the rest of the help text.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- AddSeederVersion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 10048 Build 17933: Default Diff Build & Tests Build 17932: arc lint + arc unit
Event Timeline
Comment Actions
Good call, but this needs to be consistent accross executables.
src/seeder/main.cpp | ||
---|---|---|
73 ↗ | (On Diff #17298) | Yes keep that line even when showing help. See bitcoin-cli or bitcoin-tx for exemple. |