Page MenuHomePhabricator

depends: Purge libtool archives
ClosedPublic

Authored by Fabien on Mar 31 2020, 15:02.

Details

Summary
  We use pkg-config where we can, which generally replaces libtool at a
  higher level and does not have the same downsides as libtool. These
  archives sit in our depends tree with no purpose and pollute the final
  bitcoin build with massive overlinking.

See here for an explanation of the various problems libtool archives can
cause:
https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Handling_Libtool_Archives

Backport of core PR15844.

This does actually more that described, as it includes PR16041 (it was
merged as 1 PR instead of 2).

Test Plan

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15844
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10053
Build 17942: Default Diff Build & Tests
Build 17941: arc lint + arc unit