Page MenuHomePhabricator

depends: xtrans: Configure flags cleanup.
ClosedPublic

Authored by Fabien on Mar 31 2020, 16:35.

Details

Summary
xtrans does not understand the --with-pic and --disable-shared flags we
pass it because it is not a library. Instead, we should pass it flags
that disable features/packages we're not using so they don't get a
chance to sneak in.

Backport of core PR16183.

Test Plan

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16183
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10055
Build 17945: Default Diff Build & Tests
Build 17944: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Mar 31 2020, 16:36

Pending gitian builds

Fabien requested review of this revision.Mar 31 2020, 18:21
This revision is now accepted and ready to land.Mar 31 2020, 20:45