Page MenuHomePhabricator

Modify Berkeley DB 4.8 install instructions so that it can be installed in a different directory
ClosedPublic

Authored by Mengerian on Sep 26 2017, 21:48.

Details

Test Plan

Installed BDB 4.8 by pasting the commands into terminal, then typed "make check"
Behaves as expected

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Do we really want to keep that ? I think we should just get rid of the constraint that BDB4.8 is required.

@deadalnix Sure, getting rid of the dependency on BDB 4.8 seems like a better long-term direction.

I'm not sure of the implications of that though. right now it requires configuring with "--with-incompatible-bdb"

This is what it says in doc/build-unix.md:

"Ubuntu and Debian have their own libdb-dev and libdb++-dev packages, but these will install BerkeleyDB 5.1 or later, which break binary wallet compatibility with the distributed executables which are based on BerkeleyDB 4.8. If you do not care about wallet compatibility, pass --with-incompatible-bdb to configure."

So this makes me bit nervous. I'm not sure how to test whether wallet compatibililty will be broken with BDB versions other than 4.8

So I could abandon this diff, and make another with the required changes to documentation and the makefile so that it builds with more recent BDB versions, if you tell me that's safe to do.

Yes, you can open the wallet with outdated version of the bitcoin client. We don't really care.

This revision is now accepted and ready to land.Sep 28 2017, 20:45
This revision was automatically updated to reflect the committed changes.