Differential D5636

depends: Prune X packages
ClosedPublic
Actions

Authored by Fabien on Apr 1 2020, 13:53.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING53d333669624: depends: Prune X packages
rABC53d333669624: depends: Prune X packages

Summary

We noticed that we could build QT without using XLib/libX11 as a
library. XLib/libX11's headers are still used, and a minimal
configure.ac has been added to eliminate overly-enthusiastic
configure-time dependencies that aren't actually required to obtain the
headers.

This also means that we eliminate XLib/libX11 as required shared
libraries at runtime, which is desirable.

Backport of core PR16408.

Depends on D5632.

Test Plan

Run the Gitian builds.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16408

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10075
Build 17983: Default Diff Build & Tests
Build 17982: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 1 2020, 13:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2020, 13:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10075: Diff 17353.Apr 1 2020, 14:03

Fabien added a child revision: D5638: depends: disable unused Qt features.Apr 1 2020, 15:10

deadalnix accepted this revision.Apr 1 2020, 16:45

This revision is now accepted and ready to land.Apr 1 2020, 16:45

Closed by commit rABC53d333669624: depends: Prune X packages (authored by deadalnix, committed by Fabien). · Explain WhyApr 2 2020, 09:18

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC53d333669624: depends: Prune X packages.

Fabien added a commit: rSTAGING53d333669624: depends: Prune X packages.Apr 7 2020, 23:35

Revision Contents
Changeset List

Path

Size

2 lines

build-aux/

m4/

1 line

contrib/

devtools/

symbol-check.py

2 lines

depends/

packages/

2 lines

2 lines

7 lines

patches/

qt/

69 lines

Diff 17353

.gitignore

Loading...

build-aux/m4/bitcoin_qt.m4

Loading...

contrib/devtools/symbol-check.py

Loading...

depends/packages/libX11.mk

Loading...

depends/packages/libXext.mk

Loading...

depends/packages/libxcb.mk

Loading...

depends/packages/packages.mk

Loading...

depends/packages/qt.mk

Loading...

depends/packages/xextproto.mk

Loading...

depends/packages/xtrans.mk

Loading...

depends/patches/qt/no-xlib.patch

Loading...