Page MenuHomePhabricator

Also track dependencies of native targets
ClosedPublic

Authored by deadalnix on Apr 1 2020, 16:33.

Details

Summary

Now we can have accurate dependency tracking for native targets when using ninja.

Test Plan
ninja
ninja # Check we don't rebuild any native target
touch ../src/secp256k1/src/group.h
ninja # Check that the gen_context step triggers.

Verify that the make build is still going.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Apr 2 2020, 09:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cmake/modules/CustomCommandWithDepFile.cmake
2 ↗(On Diff #17360)

featur => feature

cmake/modules/NativeExecutable.cmake
61 ↗(On Diff #17360)

I'm surprised this works ? add_custom_command expects a single DEPENDS argument.

cmake/utils/gen-ninja-deps.py
174 ↗(On Diff #17360)

Interesting, I would have expected the previous version to behave the same

This revision now requires changes to proceed.Apr 2 2020, 09:50
cmake/utils/gen-ninja-deps.py
174 ↗(On Diff #17360)

No, it fails hard.

This revision is now accepted and ready to land.Apr 2 2020, 17:10
This revision was automatically updated to reflect the committed changes.