Page MenuHomePhabricator
Differential D5641

Also track dependencies of native targets
ClosedPublic
Actions

Authored by deadalnix on Apr 1 2020, 16:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING3521a5ed6462: Also track dependencies of native targets
rABC3521a5ed6462: Also track dependencies of native targets
Summary

Now we can have accurate dependency tracking for native targets when using ninja.

Test Plan
ninja
ninja # Check we don't rebuild any native target
touch ../src/secp256k1/src/group.h
ninja # Check that the gen_context step triggers.

Verify that the make build is still going.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 1 2020, 16:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2020, 16:33
teamcity added a comment.Apr 1 2020, 16:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix edited the test plan for this revision. (Show Details)Apr 1 2020, 16:36
Harbormaster completed remote builds in B10081: Diff 17360.Apr 1 2020, 16:42
teamcity added a comment.Apr 1 2020, 16:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien requested changes to this revision.Apr 2 2020, 09:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cmake/modules/CustomCommandWithDepFile.cmake
2 ↗(On Diff #17360)

featur => feature

cmake/modules/NativeExecutable.cmake
61 ↗(On Diff #17360)

I'm surprised this works ? add_custom_command expects a single DEPENDS argument.

cmake/utils/gen-ninja-deps.py
174 ↗(On Diff #17360)

Interesting, I would have expected the previous version to behave the same

This revision now requires changes to proceed.Apr 2 2020, 09:50
deadalnix added inline comments.Apr 2 2020, 16:42
cmake/utils/gen-ninja-deps.py
174 ↗(On Diff #17360)

No, it fails hard.

deadalnix updated this revision to Diff 17394.Apr 2 2020, 16:54

Address comments

teamcity added a comment.Apr 2 2020, 16:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 2 2020, 17:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10100: Diff 17394.Apr 2 2020, 17:04
Fabien accepted this revision.Apr 2 2020, 17:10
This revision is now accepted and ready to land.Apr 2 2020, 17:10
Closed by commit rABC3521a5ed6462: Also track dependencies of native targets (authored by deadalnix). · Explain WhyApr 2 2020, 17:36
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC3521a5ed6462: Also track dependencies of native targets.
deadalnix added a commit: rSTAGING3521a5ed6462: Also track dependencies of native targets.Apr 7 2020, 23:35

Revision Contents
Changeset List

Diff 17395

View Options

cmake/modules/CustomCommandWithDepFile.cmake

Loading...
View Options

cmake/modules/NativeExecutable.cmake

Loading...
View Options

cmake/templates/NativeBuildRunner.cmake.in

Loading...
View Options

cmake/templates/NativeCmakeRunner.cmake.in

Loading...
View Options

cmake/utils/gen-ninja-deps.py

Loading...