Page MenuHomePhabricator

Add OpenSSL termios fix for musl libc
ClosedPublic

Authored by Fabien on Apr 2 2020, 13:09.

Details

Summary
Currently the version of OpenSSL included in the depends system won't
build on musl based systems because termio.h does not exist. The proper
header named termios.h does exist.

This PR adds a patch for OpenSSL to replace the termio.h header with
termios.h, which is the proper POSIX header as I understand it.

This is a known issue as TERMIOS (not TERMIO) should be the default, and
is fixed in later versions of OpenSSL. There is discussion on the
OpenSSL repo here: openssl/openssl#163

This has been fixed in OpenSSL.

This partly fixes #16925 and allows building Bitcoin on Alpine using the
depends system.

Backport of core PR16926.

Test Plan

Run the Linux Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Apr 2 2020, 13:12

Pending Gitian build

Fabien requested review of this revision.Apr 2 2020, 13:51
This revision is now accepted and ready to land.Apr 2 2020, 16:46