Differential D5660

Only pass --disable-dependency-tracking to packages that understand it
ClosedPublic
Actions

Authored by Fabien on Apr 2 2020, 19:45.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3bf909b08ebc: Only pass --disable-dependency-tracking to packages that understand it
rABC3bf909b08ebc: Only pass --disable-dependency-tracking to packages that understand it

Summary

By blanket passing --disable-dependency-tracking to all depends packages
we end up with warnings (i.e in bdb or freetype) like:
  configure: WARNING: unrecognized options:
--disable-dependency-tracking
Instead, only pass it to packages that actually understand it.
[...]
This PR also adds --enable-option-checking as a configure option to all
applicable packages.

Backport of core PR16949.

Test Plan

Run the Gitian builds.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16949

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10103
Build 18036: Default Diff Build & Tests
Build 18035: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 2 2020, 19:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2020, 19:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10103: Diff 17398.Apr 2 2020, 19:54

deadalnix accepted this revision.Apr 2 2020, 22:00

This revision is now accepted and ready to land.Apr 2 2020, 22:00

Closed by commit rABC3bf909b08ebc: Only pass --disable-dependency-tracking to packages that understand it (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyApr 3 2020, 07:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3bf909b08ebc: Only pass --disable-dependency-tracking to packages that understand it.

Fabien added a commit: rSTAGING3bf909b08ebc: Only pass --disable-dependency-tracking to packages that understand it.Apr 7 2020, 23:37

Revision Contents
Changeset List

Path

Size

depends/

2 lines

packages/

2 lines

1 line

1 line

1 line

1 line

1 line

1 line

2 lines

1 line

2 lines

1 line

5 lines

Diff 17398

depends/funcs.mk

Loading...

depends/packages/bdb.mk

Loading...

depends/packages/expat.mk

Loading...

depends/packages/fontconfig.mk

Loading...

depends/packages/freetype.mk

Loading...

depends/packages/libXau.mk

Loading...

depends/packages/libevent.mk

Loading...

depends/packages/libxcb.mk

Loading...

depends/packages/protobuf.mk

Loading...

depends/packages/qrencode.mk

Loading...

depends/packages/xcb_proto.mk

Loading...

depends/packages/xproto.mk

Loading...

depends/packages/zeromq.mk

Loading...