Differential D5667

depends: don't configure xcb_proto
ClosedPublic
Actions

Authored by Fabien on Apr 3 2020, 09:46.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING42d685f0f440: depends: don't configure xcb_proto
rABC42d685f0f440: depends: don't configure xcb_proto

Summary

xcb_proto's configure doesn't understand --disable-shared or
--with-pic. All the package does it put a stack of xml files into
a directory to be used by libxcb.

Backport of core PR17698.

Test Plan

Run the Linux Gitian builds.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17698

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10118
Build 18064: Default Diff Build & Tests
Build 18063: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 3 2020, 09:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2020, 09:46

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10118: Diff 17431.Apr 3 2020, 10:10

deadalnix accepted this revision.Apr 3 2020, 13:18

This revision is now accepted and ready to land.Apr 3 2020, 13:18

Closed by commit rABC42d685f0f440: depends: don't configure xcb_proto (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyApr 3 2020, 15:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC42d685f0f440: depends: don't configure xcb_proto.

Fabien added a commit: rSTAGING42d685f0f440: depends: don't configure xcb_proto.Apr 7 2020, 21:50

Revision Contents
Changeset List

Path

Size

depends/

packages/

xcb_proto.mk

5 lines

Diff 17431

View Options

depends/packages/xcb_proto.mk

depends: don't configure xcb_protoClosedPublicActions