Page MenuHomePhabricator

depends: fix boost mac cross build with clang 9+
ClosedPublic

Authored by Fabien on Apr 3 2020, 15:14.

Details

Summary
The ancient "darwin-4.9.1" profile has long been used to match against
clang, which prior to version 9, reported 4.9.1 as its version when
invoking "clang++ -dumpversion". Presumably this was a historical
compatibility quirk related to Apple's switch from gcc to clang.

This was "fixed" in clang 9.0, so that -dumpversion reports the real
version. Unfortunately that had the side-effect of breaking the
(brittle) boost compiler detection.

Move to the seemingly more-correct "clang-darwin" profile, which passes
the checks and builds correctly.

Also switch to using ar rather than libtool for archiving, as it's what
the clang-darwin profile expects to be using.

Note that because this is using a different profile, some of the final
command-line arguments end up changing. The changes look sane at a
glance.

Backport of core PR17231.

Test Plan

Run the OSX Gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Apr 3 2020, 15:14

Pending Gitian build.

Fabien requested review of this revision.Apr 3 2020, 15:21
This revision is now accepted and ready to land.Apr 3 2020, 16:34