HomePhabricator

depends: fix boost mac cross build with clang 9+

Description

depends: fix boost mac cross build with clang 9+

Summary:

The ancient "darwin-4.9.1" profile has long been used to match against
clang, which prior to version 9, reported 4.9.1 as its version when
invoking "clang++ -dumpversion". Presumably this was a historical
compatibility quirk related to Apple's switch from gcc to clang.

This was "fixed" in clang 9.0, so that -dumpversion reports the real
version. Unfortunately that had the side-effect of breaking the
(brittle) boost compiler detection.

Move to the seemingly more-correct "clang-darwin" profile, which passes
the checks and builds correctly.

Also switch to using ar rather than libtool for archiving, as it's what
the clang-darwin profile expects to be using.

Note that because this is using a different profile, some of the final
command-line arguments end up changing. The changes look sane at a
glance.

Backport of core PR17231.

Test Plan: Run the OSX Gitian build.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5672

Details

Provenance
Cory Fields <cory-nospam-@coryfields.com>Authored on Oct 23 2019, 15:45
FabienCommitted on Apr 6 2020, 13:48
FabienPushed on Apr 6 2020, 14:28
Reviewer
Restricted Project
Differential Revision
D5672: depends: fix boost mac cross build with clang 9+
Parents
rSTAGING1e2d2d1d81a4: Reword confusing warning message in RPC linter
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/17460, tag: phabricator/base/17459