Page MenuHomePhabricator
Differential D5680

depends: only use D-Bus with Qt on linux
ClosedPublic
Actions

Authored by Fabien on Apr 6 2020, 15:19.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe9dd003a97e4: depends: only use D-Bus with Qt on linux
rABCe9dd003a97e4: depends: only use D-Bus with Qt on linux
Summary
Since #8210 we've been passing -dbus-runtime when configuring Qt,
however D-Bus isn't used on macOS or Windows. So rather than blanket
passing -dbus-runtime, only use D-Bus when building for linux, and
disable it for Windows and macOS. This also saves some time building qt
in depends (for windows or macOS).

Backport of core PR17521.

Depends on D5679.

Test Plan

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 6 2020, 15:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2020, 15:19
teamcity edited the summary of this revision. (Show Details)Apr 6 2020, 15:19

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 6 2020, 15:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien planned changes to this revision.Apr 6 2020, 15:21

Pending Gitian builds.

teamcity added a comment.Apr 6 2020, 15:22

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

teamcity added a comment.Apr 6 2020, 15:22

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.Apr 6 2020, 15:22

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.Apr 6 2020, 15:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10136: Diff 17461.Apr 6 2020, 15:28
teamcity added a comment.Apr 6 2020, 15:31

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

teamcity added a comment.Apr 6 2020, 15:33

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

teamcity added a comment.Apr 6 2020, 16:01

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Fabien requested review of this revision.Apr 7 2020, 07:48
deadalnix accepted this revision.Apr 7 2020, 23:21
This revision is now accepted and ready to land.Apr 7 2020, 23:21
Closed by commit rABCe9dd003a97e4: depends: only use D-Bus with Qt on linux (authored by Fabien). · Explain WhyApr 8 2020, 13:19
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe9dd003a97e4: depends: only use D-Bus with Qt on linux.
Fabien added a commit: rSTAGINGe9dd003a97e4: depends: only use D-Bus with Qt on linux.May 5 2020, 18:54

Revision Contents
Changeset List

PathSize
depends/
packages/
10 lines

Diff 18695

View Options

depends/packages/qt.mk

Loading...