Page MenuHomePhabricator
Differential D5696

Remove 'boost::optional'-related gcc warnings
ClosedPublic
Actions

Authored by Fabien on Apr 10 2020, 15:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING816f2c7bbd71: Remove 'boost::optional'-related gcc warnings
rABC816f2c7bbd71: Remove 'boost::optional'-related gcc warnings
Summary

Backport of core PR15292.

Test Plan

With GCC:

ninja check

Make sure the warnings are gone (tested with GCC 7.5).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15292
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10167
Build 18160: Default Diff Build & Tests
Build 18159: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 10 2020, 15:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2020, 15:47
teamcity edited the summary of this revision. (Show Details)Apr 10 2020, 15:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 10 2020, 15:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 10 2020, 15:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10167: Diff 18726.Apr 10 2020, 15:59
deadalnix accepted this revision.Apr 10 2020, 22:02
This revision is now accepted and ready to land.Apr 10 2020, 22:02
Closed by commit rABC816f2c7bbd71: Remove 'boost::optional'-related gcc warnings (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyApr 11 2020, 11:07
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC816f2c7bbd71: Remove 'boost::optional'-related gcc warnings.
Fabien added a commit: rSTAGING816f2c7bbd71: Remove 'boost::optional'-related gcc warnings.May 5 2020, 18:56

Revision Contents
Changeset List

PathSize
src/
7 lines
wallet/
8 lines
4 lines

Diff 18726

View Options

src/optional.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...