Page MenuHomePhabricator

Use full sanitizer options on CI
ClosedPublic

Authored by Fabien on Apr 11 2020, 13:12.

Details

Summary

Since the unit tests can be run through the executable (and not using a
ninja command), the full options need to be set to be effective.

Partial revert of D5695 (for the CI part).

Test Plan

Run the CI sanitizer builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien planned changes to this revision.Apr 11 2020, 13:13

Pending TSAN build

Fabien requested review of this revision.Apr 11 2020, 13:54
deadalnix requested changes to this revision.Apr 12 2020, 01:03
deadalnix added a subscriber: deadalnix.

Reduplicating behavior seems like the worst possible way to fix this.

This revision now requires changes to proceed.Apr 12 2020, 01:03

Reduce variable scope to avoid duplicated options.

Snippet of first build failure:

[08:02:29] :		 [VCS Root: Bitcoin ABC Staging] Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git) (3s)
[08:02:29] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git config http.sslCAInfo
[08:02:29] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref
[08:02:29] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= ls-remote origin
[08:02:30] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/18749
[08:02:30] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/18749
[08:02:31] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749 (1s)
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Enumerating objects: 9, done.        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  11% (1/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  22% (2/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  33% (3/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  44% (4/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  55% (5/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  66% (6/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  77% (7/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects:  88% (8/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects: 100% (9/9)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Counting objects: 100% (9/9), done.        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  20% (1/5)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  40% (2/5)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  60% (3/5)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  80% (4/5)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects: 100% (5/5)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects: 100% (5/5), done.        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Total 5 (delta 4), reused 0 (delta 0)        
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/diff/18749 -> phabricator/diff/18749
[08:02:32]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18749 -> phabricator/base/18749
[08:02:32] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 5772b22cd0f4aa923ecd666d363c3cc8c77c1580 --
[08:02:32] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[08:02:32] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18749
[08:02:32] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 5772b22cd0f4aa923ecd666d363c3cc8c77c1580 --
[08:02:33] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/18749
[08:02:33] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18749
[08:02:33] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[08:02:33] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[08:02:33] : Build preparation done
[08:02:33]E: Step 1/2: Command Line (7m)
[08:02:33] :	 [Step 1/2] Ant JUnit report watcher
[08:02:33] :		 [Ant JUnit report watcher] Watching paths:
[08:02:33] :		 [Ant JUnit report watcher] +:/tmp/abc-build-results/build/test_bitcoin.xml
[08:02:33] :		 [Ant JUnit report watcher] +:/tmp/abc-build-results/build/**/junit_results*.xml
[08:02:33] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script7383647449666168352
[08:02:33] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[08:02:33] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[08:02:33] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[08:02:33] :	 [Step 1/2] Pulling latest cache...
[08:02:33] :	 [Step 1/2] Building base image for: 5772b22cd...
[08:02:33] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[08:02:33] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[08:02:33] :	 [Step 1/2] Tag name: abc-base-image-5772b22cd
[08:09:33]W:	 [Step 1/2] Process exited with code 1
[08:09:33]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Snippet of first build failure:

[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  80% (45/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  82% (46/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  83% (47/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  85% (48/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  87% (49/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  89% (50/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  91% (51/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  92% (52/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  94% (53/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  96% (54/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects:  98% (55/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects: 100% (56/56)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Compressing objects: 100% (56/56), done.        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] remote: Total 56 (delta 45), reused 0 (delta 0)        
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/diff/18749 -> phabricator/diff/18749
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18734 -> phabricator/base/18734
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18731 -> phabricator/base/18731
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18732 -> phabricator/base/18732
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18735 -> phabricator/base/18735
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18737 -> phabricator/base/18737
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18740 -> phabricator/base/18740
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18744 -> phabricator/base/18744
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18745 -> phabricator/base/18745
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18746 -> phabricator/base/18746
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18747 -> phabricator/base/18747
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18748 -> phabricator/base/18748
[08:03:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18749:refs/tags/phabricator/diff/18749]  * [new tag]             phabricator/base/18749 -> phabricator/base/18749
[08:03:04] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 5772b22cd0f4aa923ecd666d363c3cc8c77c1580 --
[08:03:04] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[08:03:04] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18749
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 5772b22cd0f4aa923ecd666d363c3cc8c77c1580 --
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/18749
[08:03:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18749
[08:03:05] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[08:03:05] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[08:03:05] : Build preparation done
[08:03:05]E: Step 1/2: Command Line (6m:32s)
[08:03:05] :	 [Step 1/2] Ant JUnit report watcher
[08:03:05] :		 [Ant JUnit report watcher] Watching paths:
[08:03:05] :		 [Ant JUnit report watcher] +:/tmp/abc-build-results/build/test_bitcoin.xml
[08:03:05] :		 [Ant JUnit report watcher] +:/tmp/abc-build-results/build/**/junit_results*.xml
[08:03:05] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script8969347235957605735
[08:03:05] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[08:03:05] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[08:03:05] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[08:03:05] :	 [Step 1/2] Pulling latest cache...
[08:03:06] :	 [Step 1/2] Building base image for: 5772b22cd...
[08:03:06] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[08:03:06] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[08:03:06] :	 [Step 1/2] Tag name: abc-base-image-5772b22cd
[08:09:37]W:	 [Step 1/2] Process exited with code 1
[08:09:37]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Rebase, hopefully will make the CI happy.

This revision is now accepted and ready to land.Apr 13 2020, 12:47
This revision was automatically updated to reflect the committed changes.