Allow to extend and override the sanitizers options
ClosedPublic
Actions

Authored by Fabien on Apr 10 2020, 14:52.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4dcb27a85665: Allow to extend and override the sanitizers options
rABC4dcb27a85665: Allow to extend and override the sanitizers options

Summary

This cause the values from the user environment to be appended to the
options, allowing for adding options or overriding some. Update the CI
to use this feature.

Depends on D5689.

Test Plan

Run the build-asan, build-ubsan and build-tsan CI builds.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 10 2020, 14:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2020, 14:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10166: Diff 18725.Apr 10 2020, 15:09

jasonbcox added a subscriber: jasonbcox.Apr 10 2020, 17:07

jasonbcox added inline comments.

contrib/teamcity/build-configurations.sh
42 ↗	(On Diff #18725)	Where do these logs default to when log_path is not set? stdout?

Fabien added inline comments.Apr 10 2020, 17:10

contrib/teamcity/build-configurations.sh
42 ↗	(On Diff #18725)	Yes to stdout

jasonbcox accepted this revision.Apr 10 2020, 17:16

jasonbcox added inline comments.

contrib/teamcity/build-configurations.sh
42 ↗	(On Diff #18725)	Consider renaming these to ADDITIONAL_xSAN_OPTIONS to make it clear that these are not the only options being applied.

This revision is now accepted and ready to land.Apr 10 2020, 17:16

Fabien added inline comments.Apr 10 2020, 19:29

contrib/teamcity/build-configurations.sh
42 ↗	(On Diff #18725)	The option name is defined by the sanitizers. This also allow to override the value from the build system if desired.

Closed by commit rABC4dcb27a85665: Allow to extend and override the sanitizers options (authored by Fabien). · Explain WhyApr 11 2020, 11:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4dcb27a85665: Allow to extend and override the sanitizers options.

Fabien mentioned this in D5702: Use full sanitizer options on CI.Apr 11 2020, 13:12

Fabien mentioned this in rABCcb57c10dfa82: Use full sanitizer options on CI.Apr 13 2020, 12:50

Fabien added a commit: rSTAGING4dcb27a85665: Allow to extend and override the sanitizers options.May 5 2020, 18:55

Fabien mentioned this in rSTAGINGcb57c10dfa82: Use full sanitizer options on CI.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

Sanitizers.cmake

8 lines

contrib/

teamcity/

build-configurations.sh

8 lines

Diff 18742

View Options

cmake/modules/Sanitizers.cmake