Page MenuHomePhabricator
Differential D5709

[backport] Scripts and tools: Fix BIND_NOW check in security-check.py
ClosedPublic
Actions

Authored by majcosta on Apr 13 2020, 16:23.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGa29ca6e51357: [backport] Scripts and tools: Fix BIND_NOW check in security-check.py
rABCa29ca6e51357: [backport] Scripts and tools: Fix BIND_NOW check in security-check.py
Summary

37d363dd4acf7d41196d44b295593019add241c3 Tools: fix BIND_NOW check in security-check.py (Conrado Gouvea)

Pull request description:

Previously, the BIND_NOW check would work only if it was the first value in FLAGS.

Tree-SHA512: 39cd83f673a6b521803be5585ada516f2db4eede718f0c5aea3377825ed1adcefed5bbb41dd9a5f24a26f7d27116cfc81bde7e26283232593b72768c5ae3d321

This is a backport of Core PR13647

Test Plan

compile a "Hello, world!" C program with both:

gcc helloworld.c -o test_normal
gcc -Wl,-z,now -fstack-protector-all helloworld.c -o test_bindnow_canary

running ./security-check.py test_normal returns test_normal: failed RELRO Canary
running ./security-check.py test_bindnow_canary returns nothing

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 13 2020, 16:23
Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 16:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 16:23
teamcity edited the summary of this revision. (Show Details)Apr 13 2020, 16:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 13 2020, 16:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 13 2020, 16:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10191: Diff 18763.Apr 13 2020, 16:39
deadalnix accepted this revision.Apr 13 2020, 17:38
This revision is now accepted and ready to land.Apr 13 2020, 17:38
deadalnix requested changes to this revision.Apr 13 2020, 17:38

The test plan is not appropriate.

This revision now requires changes to proceed.Apr 13 2020, 17:38
majcosta requested review of this revision.Apr 13 2020, 21:54
majcosta edited the test plan for this revision. (Show Details)

corrected test plan

deadalnix accepted this revision.Apr 13 2020, 22:29
This revision is now accepted and ready to land.Apr 13 2020, 22:29
Closed by commit rABCa29ca6e51357: [backport] Scripts and tools: Fix BIND_NOW check in security-check.py (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyApr 13 2020, 22:31
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa29ca6e51357: [backport] Scripts and tools: Fix BIND_NOW check in security-check.py.
majcosta added a commit: rSTAGINGa29ca6e51357: [backport] Scripts and tools: Fix BIND_NOW check in security-check.py.May 5 2020, 18:56

Revision Contents
Changeset List

PathSize
contrib/
devtools/
2 lines

Diff 18783

View Options

contrib/devtools/security-check.py

Loading...