Page MenuHomePhabricator
Differential D5713

Pass rpc/misc RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 13 2020, 18:17.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5850294bc6e7: Pass rpc/misc RPC argument descriptions to RPCHelpMan
rABC5850294bc6e7: Pass rpc/misc RPC argument descriptions to RPCHelpMan
Summary

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched D5713diff

Verify the changes in D5713diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5713diff:

D5713diff2 KBDownload

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 13 2020, 18:17
Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 18:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 18:17
nakihito planned changes to this revision.Apr 13 2020, 18:17
teamcity edited the summary of this revision. (Show Details)Apr 13 2020, 18:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 13 2020, 18:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 18:18
Harbormaster failed remote builds in B10196: Diff 18772!Apr 13 2020, 19:18
teamcity added a comment.Apr 13 2020, 19:18
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

Build 'Bitcoin-ABC / Diffs / Diff Testing' #8969, branch 'phabricator/diff/18772'
Started 2020-04-13 18:18:23 on 'highperf3' by 'Phabricator Staging (phabricator-staging)'
Finished 2020-04-13 19:18:37 with status FAILURE 'Execution timeout (new)'
nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 23:08
teamcity added a comment.Apr 13 2020, 23:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 13 2020, 23:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

nakihito requested review of this revision.Apr 13 2020, 23:44
nakihito added a child revision: D5726: Complete PR14796 by cleaning up some old functions and names.Apr 14 2020, 00:20
teamcity added a comment.Apr 14 2020, 00:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:36
teamcity added a comment.Apr 14 2020, 00:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10196: Diff 18772.Apr 14 2020, 00:47
jasonbcox accepted this revision.Apr 14 2020, 00:55
This revision is now accepted and ready to land.Apr 14 2020, 00:55
nakihito updated this revision to Diff 18801.Apr 14 2020, 18:37

Rebase and linter.

teamcity added a comment.Apr 14 2020, 19:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 14 2020, 20:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10215: Diff 18801.Apr 14 2020, 20:06
Closed by commit rABC5850294bc6e7: Pass rpc/misc RPC argument descriptions to RPCHelpMan (authored by nakihito). · Explain WhyApr 15 2020, 17:36
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC5850294bc6e7: Pass rpc/misc RPC argument descriptions to RPCHelpMan.
nakihito added a commit: rSTAGING5850294bc6e7: Pass rpc/misc RPC argument descriptions to RPCHelpMan.May 5 2020, 18:58

Revision Contents
Changeset List

PathSize
src/
rpc/
178 lines

Diff 18834

View Options

src/rpc/misc.cpp

Loading...