Page MenuHomePhabricator

Remove op== on PSBTs; check compatibility in Merge
ClosedPublic

Authored by Fabien on Apr 15 2020, 12:02.

Details

Summary
Remove the op== on PartiallySignedTransaction, which only checks that
the CTransactions are equal. Instead, check this directly in Merge, and
return false if the CTransactions are not equal (so the PSBTs cannot be
merged.)

Partial backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/78b9893d020e8b1351565f1adbf591cb32f6dc90

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14978_part5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10235
Build 18293: Default Diff Build & Tests
Build 18292: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Apr 15 2020, 15:48
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/psbt.cpp
20 ↗(On Diff #18825)

txhash or txid ?

This revision now requires changes to proceed.Apr 15 2020, 15:48
This revision is now accepted and ready to land.Apr 16 2020, 13:38