Differential D5739

Switch away from exceptions in refactored tx code
ClosedPublic
Actions

Authored by Fabien on Apr 15 2020, 12:42.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0a01c8cf9d86: Switch away from exceptions in refactored tx code
rABC0a01c8cf9d86: Switch away from exceptions in refactored tx code

Summary

After refactoring general-purpose PSBT and transaction code out of RPC
code, for use in the GUI, it's no longer appropriate to throw
exceptions. Instead we now return bools for success, and take an output
parameter for an error object.
We still use JSONRPCError() for the error objects, since only RPC
callers actually care about the error codes.

Partial backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/bd0dbe8763fc3029cf96531c9ccaba280b939445

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 15 2020, 12:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2020, 12:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10231: Diff 18826.Apr 15 2020, 12:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien added a child revision: D5740: Factor out combine / finalize / extract PSBT helpers.Apr 15 2020, 13:10

deadalnix accepted this revision.Apr 15 2020, 15:45

This revision is now accepted and ready to land.Apr 15 2020, 15:45

Closed by commit rABC0a01c8cf9d86: Switch away from exceptions in refactored tx code (authored by Glenn Willen <gwillen@nerdnet.org>, committed by Fabien). · Explain WhyApr 16 2020, 13:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0a01c8cf9d86: Switch away from exceptions in refactored tx code.

Fabien added a commit: rSTAGING0a01c8cf9d86: Switch away from exceptions in refactored tx code.May 5 2020, 18:59

Revision Contents
Changeset List

Path

Size

src/

node/

34 lines

transaction.cpp

58 lines

1 line

rpc/

rawtransaction.cpp

10 lines

5 lines

27 lines

wallet/

18 lines

18 lines

15 lines

test/

psbt_wallet_tests.cpp

4 lines

Diff 18863

src/node/transaction.h

Loading...

src/node/transaction.cpp

Loading...

src/psbt.h

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/rpc/util.h

Loading...

src/rpc/util.cpp

Loading...

src/wallet/psbtwallet.h

Loading...

src/wallet/psbtwallet.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/test/psbt_wallet_tests.cpp

Loading...