Page MenuHomePhabricator
Differential D5743

Merge #15943: tests: Fail if RPC has been added without tests
ClosedPublic
Actions

Authored by nakihito on Apr 16 2020, 00:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests
rABCc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests
Summary

fad0ce59e9 tests: Fail if RPC has been added without tests (MarcoFalke)

Pull request description:

Need to be run with --coverage

ACKs for commit fad0ce:

ryanofsky:
  utACK fad0ce59e9154f9b7e61907a71c740a942c60282. New comment in travis.yml is the only change since last review.

Tree-SHA512: b53632dfe9865ec06991bfcba2fd67238bebbb866b355f09624eaf233257b2bca902caac6c24abb358b2f4c1c43f28ca75e30982765911e1a117102df65276d9

Backport of Core PR15943

Test Plan
test_runner.py --coverage --extended

Verify All RPC commands covered. is printed to the console.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 16 2020, 00:16
Owners added a reviewer: Restricted Owners Package.Apr 16 2020, 00:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2020, 00:16
teamcity edited the summary of this revision. (Show Details)Apr 16 2020, 00:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 16 2020, 00:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 16 2020, 00:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10242: Diff 18850.Apr 16 2020, 00:35
Fabien accepted this revision.Apr 16 2020, 15:19
This revision is now accepted and ready to land.Apr 16 2020, 15:19
Closed by commit rABCc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyApr 16 2020, 18:00
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests.
nakihito added a commit: rSTAGINGc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests.May 5 2020, 19:00

Revision Contents
Changeset List

PathSize
test/
functional/
7 lines
10 lines

Diff 18867

View Options

test/functional/rpc_misc.py

Loading...
View Options

test/functional/test_runner.py

Loading...