HomePhabricator

Complete PR14796 by cleaning up some old functions and names

Description

Complete PR14796 by cleaning up some old functions and names

Summary:
Finish PR14796 by removing and/or renaming old functions in
rpc/util.

Renaming done with sed "s/ToStringWithArgs/ToString/g" <files>

Depends on D5710, D5712, D5713, D5714. D5716, D5717, D5720, D5722, D5725, D5732

Test Plan:

mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched finisheddiff

Verify there is no finisheddiff.

Scripts:


Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5726

Details

Provenance
nakihitoAuthored on Apr 14 2020, 00:12
nakihitoPushed on Apr 15 2020, 22:28
Reviewer
Restricted Owners Package
Differential Revision
D5726: Complete PR14796 by cleaning up some old functions and names
Parents
rABCa0950966fd85: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to…
Branches
Unknown
Tags
Unknown