Page MenuHomePhabricator
Differential D5720

Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 13 2020, 21:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc69d41b2bc44: Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan
rABCc69d41b2bc44: Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan
Summary

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched D5720diff.txt

Verify the changes in D5720diff.txt.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5720diff:

D5720diff.txt10 KBDownload

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 13 2020, 21:01
Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 21:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 21:01
nakihito planned changes to this revision.Apr 13 2020, 21:01
teamcity edited the summary of this revision. (Show Details)Apr 13 2020, 21:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 13 2020, 21:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 13 2020, 21:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10203: Diff 18780.Apr 13 2020, 21:12
nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 22:45
nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 23:11
nakihito requested review of this revision.Apr 13 2020, 23:13
nakihito edited the test plan for this revision. (Show Details)
nakihito mentioned this in D5726: Complete PR14796 by cleaning up some old functions and names.Apr 14 2020, 00:20
nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:37
Fabien requested changes to this revision.Apr 14 2020, 12:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
1107 ↗(On Diff #18780)

STR_HEX was better

1117 ↗(On Diff #18780)

Base58 is not hex

This revision now requires changes to proceed.Apr 14 2020, 12:44
nakihito updated this revision to Diff 18807.Apr 14 2020, 20:23

Addressed critiques.

nakihito planned changes to this revision.Apr 14 2020, 20:23
nakihito requested review of this revision.Apr 14 2020, 20:24
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 14 2020, 20:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 20:30
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 14 2020, 20:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10218: Diff 18807.Apr 14 2020, 20:35
Fabien accepted this revision.Apr 15 2020, 06:43
This revision is now accepted and ready to land.Apr 15 2020, 06:43
Closed by commit rABCc69d41b2bc44: Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan (authored by nakihito). · Explain WhyApr 15 2020, 17:54
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc69d41b2bc44: Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan.
nakihito mentioned this in rABC02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.Apr 15 2020, 22:28
nakihito added a commit: rSTAGINGc69d41b2bc44: Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan.May 5 2020, 18:58
nakihito mentioned this in rSTAGING02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.
PiRK mentioned this in D8112: clarify RPC rawtransaction documentation.Oct 25 2020, 14:04
PiRK mentioned this in rABC406d1a214553: clarify RPC rawtransaction documentation.Oct 26 2020, 09:53

Revision Contents
Changeset List

PathSize
src/
rpc/
763 lines

Diff 18835

View Options

src/rpc/rawtransaction.cpp

Loading...