Page MenuHomePhabricator

Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan
ClosedPublic

Authored by nakihito on Apr 13 2020, 21:01.

Details

Summary

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched D5720diff.txt

Verify the changes in D5720diff.txt.

Scripts:


D5720diff:

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14796-rawtransaction
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10203
Build 18231: Default Diff Build & Tests
Build 18230: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 21:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the test plan for this revision. (Show Details)
Fabien requested changes to this revision.Apr 14 2020, 12:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
1107

STR_HEX was better

1117

Base58 is not hex

This revision now requires changes to proceed.Apr 14 2020, 12:44
nakihito edited the test plan for this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Apr 15 2020, 06:43