Pass wallet/rpcdump RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 13 2020, 19:29.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGb8e343ee301f: Pass wallet/rpcdump RPC argument descriptions to RPCHelpMan
rABCb8e343ee301f: Pass wallet/rpcdump RPC argument descriptions to RPCHelpMan

Summary

Partial backport of Core PR14796

Test Plan

mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched D5717diff

Verify the changes in D5717diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5717diff:

D5717diff4 KBDownload

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 13 2020, 19:29

Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 19:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 19:29

nakihito planned changes to this revision.Apr 13 2020, 19:29

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10200: Diff 18776.Apr 13 2020, 19:40

Rebased.

nakihito planned changes to this revision.Apr 13 2020, 22:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito requested review of this revision.Apr 13 2020, 22:45

nakihito edited the test plan for this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10206: Diff 18784.Apr 13 2020, 22:55

nakihito mentioned this in D5726: Complete PR14796 by cleaning up some old functions and names.Apr 14 2020, 00:20

nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:37

Fabien added a subscriber: Fabien.Apr 14 2020, 12:21

Fabien added inline comments.

src/wallet/rpcdump.cpp
114 ↗	(On Diff #18784)	Is there a missing backport here ?

There are what looks like API changes in there. The output is completely different.

This revision now requires changes to proceed.Apr 14 2020, 13:10

nakihito added inline comments.Apr 14 2020, 20:37

src/wallet/rpcdump.cpp
114 ↗	(On Diff #18784)	Yes, it was something I was trying to get working before (https://github.com/bitcoin/bitcoin/pull/13381/files), but forgot to fix the help text after rebasing. For now, I'll revert the change and then adjust the missing backport to account for this change.