Page MenuHomePhabricator
Differential D5747

[backport#14618] rpc: Make HTTP RPC debug logging more informative
ClosedPublic
Actions

Authored by majcosta on Apr 16 2020, 21:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd6c2ce7439d7: [backport#14618] rpc: Make HTTP RPC debug logging more informative
rABCd6c2ce7439d7: [backport#14618] rpc: Make HTTP RPC debug logging more informative
Summary

ab8c6f24d28ea1d1e6258cf316b4b97a0baf2377 Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986) (practicalswift)
991248649b76a5a071e1360a700f3e2ecf3e1e1f rpc: Make HTTP RPC debug logging more informative (practicalswift)

Pull request description:

  • Make HTTP RPC debug logging more informative
  • Avoid excessively large log messages (which could theoretically fill up the disk) when running with debug option -debug=http

Tree-SHA512: 9068862fb7d34db1e12e6b9dde78b669b86c65b4fed3ea8c9eb6c35310d77fd12b16644728fd7e9fbf25059d25114bded9e061eb3de649d8847486ec42041ce9

This is a backport of Core PR14618

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 16 2020, 21:21
Owners added a reviewer: Restricted Owners Package.Apr 16 2020, 21:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2020, 21:21
teamcity edited the summary of this revision. (Show Details)Apr 16 2020, 21:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 16 2020, 21:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 16 2020, 21:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10255: Diff 18875.Apr 16 2020, 21:35
deadalnix accepted this revision.Apr 17 2020, 00:29
This revision is now accepted and ready to land.Apr 17 2020, 00:29
Closed by commit rABCd6c2ce7439d7: [backport#14618] rpc: Make HTTP RPC debug logging more informative (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyApr 17 2020, 01:01
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd6c2ce7439d7: [backport#14618] rpc: Make HTTP RPC debug logging more informative.
majcosta added a commit: rSTAGINGd6c2ce7439d7: [backport#14618] rpc: Make HTTP RPC debug logging more informative.May 5 2020, 19:00

Revision Contents
Changeset List

PathSize
src/
16 lines
util/
2 lines
2 lines

Diff 18879

View Options

src/httpserver.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...