HomePhabricator

[backport#14628] Rename misleading 'defaultPort' to 'http_port'

Description

[backport#14628] Rename misleading 'defaultPort' to 'http_port'

Summary:
4ed730802f9ec3d65477a29a318dd78216ef7085 scripted-diff: Rename misleading 'defaultPort' to 'http_port' (Murray Nesbitt)

Pull request description:

`defaultPort` in `HTTPBindAddresses()` is misleadingly named. `defaultPort ` suggests a constant, not something that might be overridden by `-rpcport`.

Tree-SHA512: f6ae8bdc2b4a4f503e44df9efdec32c854d2dede87714399f53791d50cce6bc41c46b01d1583cfc0e3e4777c244e1c74443fa39d9da50a45e53af265b74a17d1


This is a backport of Core PR14628

Test Plan:

ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5745

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Nov 5 2018, 12:18
majcostaCommitted on Apr 16 2020, 19:18
majcostaPushed on Apr 16 2020, 19:18
Reviewer
Restricted Owners Package
Differential Revision
D5745: [backport#14628] Rename misleading 'defaultPort' to 'http_port'
Parents
rABCc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests
Branches
Unknown
Tags
Unknown