[backport#14628] Rename misleading 'defaultPort' to 'http_port'
ClosedPublic
Actions

Authored by majcosta on Apr 16 2020, 18:14.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING5eabe26068e3: [backport#14628] Rename misleading 'defaultPort' to 'http_port'
rABC5eabe26068e3: [backport#14628] Rename misleading 'defaultPort' to 'http_port'

Summary

4ed730802f9ec3d65477a29a318dd78216ef7085 scripted-diff: Rename misleading 'defaultPort' to 'http_port' (Murray Nesbitt)

Pull request description:

`defaultPort` in `HTTPBindAddresses()` is misleadingly named. `defaultPort ` suggests a constant, not something that might be overridden by `-rpcport`.

Tree-SHA512: f6ae8bdc2b4a4f503e44df9efdec32c854d2dede87714399f53791d50cce6bc41c46b01d1583cfc0e3e4777c244e1c74443fa39d9da50a45e53af265b74a17d1

This is a backport of Core PR14628

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 16 2020, 18:14

Owners added a reviewer: Restricted Owners Package.Apr 16 2020, 18:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2020, 18:14

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Diff title is wrong

This revision now requires changes to proceed.Apr 16 2020, 18:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10251: Diff 18868.Apr 16 2020, 18:44

majcosta retitled this revision from [backport#14628] Trivial: Rename misleading 'defaultPort' to 'rpc_port' to [backport#14628] Rename misleading 'defaultPort' to 'http_port'.Apr 16 2020, 18:44

fixed diff title

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10252: Diff 18869.Apr 16 2020, 19:04

deadalnix accepted this revision.Apr 16 2020, 19:05

This revision is now accepted and ready to land.Apr 16 2020, 19:05

Closed by commit rABC5eabe26068e3: [backport#14628] Rename misleading 'defaultPort' to 'http_port' (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyApr 16 2020, 19:18

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC5eabe26068e3: [backport#14628] Rename misleading 'defaultPort' to 'http_port'.

majcosta added a commit: rSTAGING5eabe26068e3: [backport#14628] Rename misleading 'defaultPort' to 'http_port'.May 5 2020, 19:00