Differential D5753

refactoring: Check IsArgKnown() early
ClosedPublic
Actions

Authored by deadalnix on Apr 17 2020, 02:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING80898a1ef38c: refactoring: Check IsArgKnown() early
rABC80898a1ef38c: refactoring: Check IsArgKnown() early

Summary

This is a partial backport of Core PR16097 : https://github.com/bitcoin/bitcoin/pull/16097/commits/e0e18a1017fa3dc5d6ebeda6ec35c4263327d17c

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 17 2020, 02:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2020, 02:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix added a child revision: D5754: Refactor InterpretNegatedOption() function.Apr 17 2020, 02:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10261: Diff 18882.Apr 17 2020, 03:06

Fabien accepted this revision.Apr 17 2020, 11:14

This revision is now accepted and ready to land.Apr 17 2020, 11:14

Closed by commit rABC80898a1ef38c: refactoring: Check IsArgKnown() early (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhyApr 17 2020, 14:43

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC80898a1ef38c: refactoring: Check IsArgKnown() early.

deadalnix added a commit: rSTAGING80898a1ef38c: refactoring: Check IsArgKnown() early.May 5 2020, 19:01

Revision Contents
Changeset List

Path

Size

src/

util/

system.cpp

45 lines

Diff 18910

View Options

refactoring: Check IsArgKnown() earlyClosedPublicActions